681897 - Failure in /testSecurity/testSubmitUnencryptedInfoWarning.js | could not validate element Name: q with value mozilla

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Remus Pop (:RemusPop)]

TEST: testSecurity/testSubmitUnencryptedInfoWarning.js:testSubmitUnencryptedInfoWarning
ERROR: could not validate element Name: q with value mozilla
WHEN: 2011-08-25
FIRST: 2011-08-18

Comment 1

[Remus Pop (:RemusPop)]

Attachment: patch v1.0(release, beta)

This error appeared due to the search page being changed. Fixed this by pointing to the new search field.
Also replaced vars with functions.

Comment 2

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/17458565

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 555682 [details] [diff] [review]
patch v1.0(release, beta)

This patch has to land on all active branches, and not only beta and release.

>+var {assert} = require("../../../lib/assertions");

Use expect here for soft assertions.

>+  var searchResultsField = new elementslib.Selector(controller.tabs.activeTab,
>+                                                    '.gsc-input[type="text"]');

Why does 'input.gsc-input' not work? I would prefer that instead of any attribute query.

>+  assert.equal(searchResultsField.getNode().value, "mozilla",
>+               "The value in the search field is mozilla");

No need to mention mozilla in the message. Just replace it with 'the expected search term'. Also use expect here.

Comment 4

[Remus Pop (:RemusPop)]

Attachment: patch v2 (release, beta)

Updated the patch accordingly.
For Aurora and Nightly we need a separate patch which skips this test because of bug 681461.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 555711 [details] [diff] [review]
patch v2 (release, beta)

> For Aurora and Nightly we need a separate patch which skips this test
> because of bug 681461.

No, this patch has to be applied to all branches, also nightly and aurora. The patch on 681461 is a totally different beast.

>-const TIMEOUT_MODAL_DIALOG = 30000;
>+const TIMEOUT_MODAL_DIALOG = 5000;

Don't change the timeout.

>+  var searchResultsField = new elementslib.Selector(controller.tabs.activeTab,
>+                                                    'input.gsc-input');
>+  expect.equal(searchResultsField.getNode().value, "mozilla",
>+               "The expected search term");

That's not what I meant. You should have only replaced 'mozilla' by the new term and not the whole string.

>-/**
>- * Map test functions to litmus tests
>- */
>-// testSubmitUnencryptedInfoWarning.meta = {litmusids : [9295]};
>-
>-// XXX: Bug 681461
>-//      Skip due to Disconnect error on Nightly and Aurora 
>-setupModule.__force_skip__ = "Bug 681461 - Disconnect failure during testrun";
>-teardownModule.__force_skip__ = "Bug 681461 - Disconnect failure during testrun";

Seems like you collide with another patch locally applied. Those lines shouldn't be in this patch.

Comment 6

[Remus Pop (:RemusPop)]

Attachment: patch v3 (all branches)

Updated the patch as requested.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 555740 [details] [diff] [review]
patch v3 (all branches)

Looks good. Thanks Remus!

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Anthony, can you please check-in this patch into all active branches once you are free? Thanks.

Comment 9

[u279076]

I only see reports of this failure on 7.0 (beta) and 3.6 (1.9.2) -- can you confirm what branches this needs to land on?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As mentioned above it needs landing on all branches. Due to bug 681461 it doesn't fail on default and aurora because of the disconnect error which happens before this test failure.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/acad19336d03 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/718ee9f21125 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/ba0bcf3b7178 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/3a2d198bc8ac (release)

Remus, could you come up with a backport of this patch which only touches the elementslib.Selector line? On 1.9.2 we do not have the assertions module so we cannot backport it completely to that branch. Thanks.

Comment 12

[Remus Pop (:RemusPop)]

Attachment: patch (1.9.2)

Only changed the searchResultsField. This applies to mozilla-1.9.2.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed backport on 1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/ae28872c0b17

Comment 14

[u279076]

@Remus thanks for the quick turnaround on this bug. Please mark this bug as VERIFIED if the failure is gone from tomorrow's reports.

Comment 15

[Remus Pop (:RemusPop)]

No longer reproducible in the test runs.