When I had added multiple injenction support by bug 653361, plugin-container crashed. Because HookSetWindowLongPtr is called several times. HookSetWindowLongPtr should not inject after 2nd times. (because return address is static!)
Comment on attachment 555996 [details] [diff] [review] fix v2 I think you want jimmm to look over this.
Attachment #555996 - Flags: review?(joshmoz) → review?(jmathies)
Originally this was a passive error, no harm came from calling AddHook more than once. If we've changed this, I wonder if there is some way we can detect it in AddHook and assert?
I went ahead and landed this as a bustage fix for Bug 684215. http://hg.mozilla.org/mozilla-central/rev/0664108eb19d
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(In reply to Jim Mathies [:jimm] from comment #4) > Originally this was a passive error, no harm came from calling AddHook more > than once. If we've changed this, I wonder if there is some way we can > detect it in AddHook and assert? No assertion on current code. But now, glandium has added TestDllIntercept test that can inject APIs.
You need to log in before you can comment on or make changes to this bug.