681944 - No "Undo closed tab" after closing a restored tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andreea Pod]

Mozilla /5.0 (Android;Linux armv7l;rv:9.0a1) Gecko/20110824 Firefox/9.0a1 Fennec/9.0a1

Mozilla /5.0 (Android;Linux armv7l;rv:7.0) Gecko/20110824 Firefox/7.0 Fennec/7.0

Device: LG Optimus 2X (Android 2.2)

Steps to reproduce:
1. Open a few tabs
2. Kill the application using a task killer
3. Open Fennec and see tabs are restored
4. Close tabs that are not in focus and are not loaded

Expected result:
Tabs should go to "undo closed tab"

Actual result:
Tabs are disappearing and you are not able to undo them, please see the video: http://www.youtube.com/watch?v=pwJL26t6pA8&feature=channel_video_title

Comment 1

[Lucas Rocha (:lucasr)]

Taking.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Remove "empty" attribute from the thumbnails of restored tabs

Comment 3

[Ed Morley [:emorley]]

Will push to inbound once try goes green:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=179780dcf805

Comment 4

[Ed Morley [:emorley]]

Previous try run failed to actually show any results and build api says that rev is 404 (no idea why), so pushed again:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=19373e00fd85

Comment 5

[Ed Morley [:emorley]]

Ok, so that try push failed to insert into the schedulerdb as well, so I've just pushed this to inbound to save spending any longer on this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5131fb5635b5

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5131fb5635b5

Comment 7

[Catalin Suciu [:csuciu]]

Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110921
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2

I was able to reproduce this issue using the initial steps.
It looks like you cannot Undo a tab closed before the page is fully loaded.

Comment 8

[Lucas Rocha (:lucasr)]

Could not reproduce this. Catalin, what do you mean by "looks like you cannot Undo a tab closed before the page is fully loaded"? Closing the restored tab before the initial page is fully loaded?

Comment 9

[Catalin Suciu [:csuciu]]

I was able to reproduce this on the latest nightly.
This are the steps:
1. Open Fennec
2. Load two heavy content pages in two new tabs (I used: www.ziare.com and www.bbc.co.uk)
3. "Force stop" nightly from Settings | App.
4. Start nightly
5. Right after nightly starts and tabs start loading, close one or both tabs. Don't wait till tabs are updated with the thumbnail picture

Actual:
"Undo closed tab" button doesn't show up.

Comment 10

[Lucas Rocha (:lucasr)]

If you remove the session-restored tab before it loads its thumbnail, we still consider the tab as "empty" and no undo operation will be offered. I can just set all session-restored tabs as non-empty before the thumbnail is even loaded to avoid this problem. Patch coming.

Comment 11

[Lucas Rocha (:lucasr)]

Attachment: Immediately remove "empty" attribute from session-restored tabs

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 562754 [details] [diff] [review]
Immediately remove "empty" attribute from session-restored tabs

Looks OK. I looked in MXR for all occurrences of "empty" in /mobile and found that tabs.xml uses it. But this change seems to not break the usage.

I also found "empty" used in a test:

http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/tests/browser_tabs.js#130

This change should not break this use either.

Comment 13

[Lucas Rocha (:lucasr)]

Yeah, this is a very specific change that only applies to session restored tabs.

Comment 14

[Lucas Rocha (:lucasr)]

Landed: http://hg.mozilla.org/integration/mozilla-inbound/rev/f3022823eb87

Mark, I guess this should land in aurora too?

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lucas Rocha (:lucasr) from comment #14)
> Landed: http://hg.mozilla.org/integration/mozilla-inbound/rev/f3022823eb87
> 
> Mark, I guess this should land in aurora too?

Not sure this is critical enough to push for Aurora. Do you think this is common enough and/or causes a bad enough problem that we want to get it into Aurora?

I assume this is a regression from Fx8, right?

Comment 16

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/f3022823eb87

Comment 17

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #15)
> (In reply to Lucas Rocha (:lucasr) from comment #14)
> > Landed: http://hg.mozilla.org/integration/mozilla-inbound/rev/f3022823eb87
> > 
> > Mark, I guess this should land in aurora too?
> 
> Not sure this is critical enough to push for Aurora. Do you think this is
> common enough and/or causes a bad enough problem that we want to get it into
> Aurora?
> 
> I assume this is a regression from Fx8, right?

I fixed this bug in Fx9 but it got reopened and fixed after the merge. This is why I was wondering whether this is Aurora material or not. I don't think it's critical to push for Aurora.

Comment 18

[Carla Nadastean]

Retested bug with:

Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110930
Firefox/10.0a1 Fennec/10.0a1
Device: Motorola DROID 2
OS: Android 2.3

and

BUILD ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110930
Firefox/9.0a2 Fennec/9.0a2

Bug is no longer reproducible. 

"Undo Closed tab" is available after closing a restored tab.

Verifying bug.