68196 - can't build rpm on same machine where rpm is installed ( problems with --with-default-mozilla-five-home )

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Christopher Blizzard (:blizzard)]

People have been reporting to me that they can't build rpms on the same machine
where mozilla is already installed.  The problem is that the utilities that have
to get run as part of the rpm build load libraries from /usr/lib/mozilla before
the libraries that they should be loading as part of the build.

Apparently not only does configure flag add a default MOZILLA_FIVE_HOME but it
adds the rpath when you link binaries.  This is bad mojo.  Can we remove this?

Comment 1

[cls]

Well, I was hoping that Ramiro would step in here as it was his checkin but
lacking that, I have no problem with removing the rpath.  The proper fix may be
to change the linking flags so that only the application binaries
(mozilla-bin,viewer,etc) link using rpath.  The helper bins (nsinstall, xpidl,
etc) should only link against the bare minimum libs.

Comment 2

[cls]

Attachment: Remove -rpath from link flags

Comment 3

[Christopher Blizzard (:blizzard)]

r=blizzard

Comment 4

[cls]

Patch has been checked in.

Comment 5

[Jon Granrose]

QA contact to blizzard to verify this fix.

Comment 6

[Christopher Blizzard (:blizzard)]

Yeah, this works now.