682060 - IonMonkey: Implement LTestDAndBranch

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

This patch implements LTestDAndBranch, LCompareD, and LCompareDAndBranch. It also refactors a lot of the comparison boilerplate.

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 557401 [details] [diff] [review]
patch

Review of attachment 557401 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/Lowering.cpp
@@ -122,5 @@
>      MDefinition *opd = test->getOperand(0);
>      MBasicBlock *ifTrue = test->ifTrue();
>      MBasicBlock *ifFalse = test->ifFalse();
>  
> -    if (opd->isConstant()) {

I am unclear on why this block was removed. If it is because constant tests are now not generated, can we assert !opd->isConstant()?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

I removed it since it was premature optimization, and rather out of place. Ideally this folding should be done in MIR, but if that's too hard and there's a situation where this optimization is necessary, we can add it back.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/ionmonkey/rev/973bcd9f92eb