Closed Bug 682073 Opened 14 years ago Closed 14 years ago

AndroidBridge uses wrong method for calling setClipboardText

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox7 fixed, firefox8 fixed, firefox9 fixed, fennec7+)

Status:
VERIFIED FIXED
Milestone:
mozilla7
Tracking Flags:
Tracking Status
firefox7 --- fixed
firefox8 --- fixed
firefox9 --- fixed
fennec 7+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

patch
1.57 KB, patch
dougt
: review+
asa
: approval-mozilla-aurora+
asa
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review
In the AndroidBridge, we use CallStaticObjectMethod when calling setClipboardText and we should use CallStaticVoidMethod: http://mxr.mozilla.org/mozilla-central/source/widget/src/android/AndroidBridge.cpp#542 http://mxr.mozilla.org/mozilla-central/source/widget/src/android/AndroidBridge.cpp#563
Attachment #555820 - Flags: review?(doug.turner)
Blocks: 676341
Attachment #555820 - Flags: review?(doug.turner) → review+
Assignee: nobody → mark.finkle
tracking-fennec: --- → ?
OS: Linux → Android
Hardware: x86 → All
http://hg.mozilla.org/mozilla-central/rev/49884897bb5c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 555820 [details] [diff] [review] patch Very simple Android-only, low-risk fix. Prevents crashes during tests and possibly an know crasher from the field (bug 676341).
Attachment #555820 - Flags: approval-mozilla-beta?
Attachment #555820 - Flags: approval-mozilla-aurora?
Attachment #555820 - Flags: approval-mozilla-beta?
Attachment #555820 - Flags: approval-mozilla-beta+
Attachment #555820 - Flags: approval-mozilla-aurora?
Attachment #555820 - Flags: approval-mozilla-aurora+
Not something QA is going to track for verification.
Whiteboard: [qa-]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: