AndroidBridge uses wrong method for calling setClipboardText

VERIFIED FIXED in Firefox 7

Status

()

Core
Widget: Android
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
mozilla7
All
Android
Points:
---

Firefox Tracking Flags

(firefox7 fixed, firefox8 fixed, firefox9 fixed, fennec7+)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Created attachment 555820 [details] [diff] [review]
patch

In the AndroidBridge, we use CallStaticObjectMethod when calling setClipboardText and we should use CallStaticVoidMethod:

http://mxr.mozilla.org/mozilla-central/source/widget/src/android/AndroidBridge.cpp#542
http://mxr.mozilla.org/mozilla-central/source/widget/src/android/AndroidBridge.cpp#563
Attachment #555820 - Flags: review?(doug.turner)
(Assignee)

Updated

6 years ago
Blocks: 676341

Updated

6 years ago
Attachment #555820 - Flags: review?(doug.turner) → review+
Assignee: nobody → mark.finkle
tracking-fennec: --- → ?
OS: Linux → Android
Hardware: x86 → All
http://hg.mozilla.org/mozilla-central/rev/49884897bb5c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 555820 [details] [diff] [review]
patch

Very simple Android-only, low-risk fix. Prevents crashes during tests and possibly an know crasher from the field (bug 676341).
Attachment #555820 - Flags: approval-mozilla-beta?
Attachment #555820 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #555820 - Flags: approval-mozilla-beta?
Attachment #555820 - Flags: approval-mozilla-beta+
Attachment #555820 - Flags: approval-mozilla-aurora?
Attachment #555820 - Flags: approval-mozilla-aurora+
Duplicate of this bug: 682734
http://hg.mozilla.org/releases/mozilla-aurora/rev/b27ee056fe19
http://hg.mozilla.org/releases/mozilla-beta/rev/5c18cbeb7da5
tracking-fennec: ? → 7+
status-firefox7: --- → fixed
status-firefox8: --- → fixed
status-firefox9: --- → fixed
Target Milestone: --- → mozilla7
Verified: see comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=682734#c4
Status: RESOLVED → VERIFIED
Not something QA is going to track for verification.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.