Value "browser.display.focus_background_color" should allow for transparent or alternate CSS value

RESOLVED FIXED in mozilla10

Status

()

Core
Layout
P3
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tomorrow, Assigned: bz)

Tracking

Trunk
mozilla10
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Since bug [url=https://bugzilla.mozilla.org/show_bug.cgi?id=641569]641569[/url] turned out invalid - submitting this instead.
Originally the problem was:

[quote]Setting "browser.display.use_focus_colors" value to "true" causes odd overlay with specific image viewer on many webpages.[/quote]

As per [url=https://bugzilla.mozilla.org/show_bug.cgi?id=641569#c9]Comment 9[/url] on the first bug it would seem that the real issue is that "browser.display.use_focus_colors" causes anything matching ":focus" and anything matching ":focus>font" to have the default focus foreground and background color unless the page styles them otherwise.
Created attachment 555934 [details] [diff] [review]
This should do it
Attachment #555934 - Flags: review?(dbaron)
Assignee: nobody → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: P5 → P3
Whiteboard: [need review]
Comment on attachment 555934 [details] [diff] [review]
This should do it

I think you should make the function take const nsString&, and make the callers use Preferences::GetString instead of GetCString.

r=dbaron with that, but note that this conflicts with bug 629882
Attachment #555934 - Flags: review?(dbaron) → review+
> I think you should make the function take const nsString&, and make the callers use
> Preferences::GetString instead of GetCString.

Done.

> but note that this conflicts with bug 629882

I'll give ms2ger a heads-up.
(Reporter)

Comment 4

6 years ago
Im glad this thing is getting somewhere finally.
https://hg.mozilla.org/integration/mozilla-inbound/rev/073b4ef6933f
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/073b4ef6933f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.