682088 - Value "browser.display.focus_background_color" should allow for transparent or alternate CSS value

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[tomorrow]

Since bug [url=https://bugzilla.mozilla.org/show_bug.cgi?id=641569]641569[/url] turned out invalid - submitting this instead.
Originally the problem was:

[quote]Setting "browser.display.use_focus_colors" value to "true" causes odd overlay with specific image viewer on many webpages.[/quote]

As per [url=https://bugzilla.mozilla.org/show_bug.cgi?id=641569#c9]Comment 9[/url] on the first bug it would seem that the real issue is that "browser.display.use_focus_colors" causes anything matching ":focus" and anything matching ":focus>font" to have the default focus foreground and background color unless the page styles them otherwise.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: This should do it

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 555934 [details] [diff] [review]
This should do it

I think you should make the function take const nsString&, and make the callers use Preferences::GetString instead of GetCString.

r=dbaron with that, but note that this conflicts with bug 629882

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I think you should make the function take const nsString&, and make the callers use
> Preferences::GetString instead of GetCString.

Done.

> but note that this conflicts with bug 629882

I'll give ms2ger a heads-up.

Comment 4

[tomorrow]

Im glad this thing is getting somewhere finally.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/073b4ef6933f

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/073b4ef6933f