682166 - Allow absolute pathnames in js console read()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Alon Zakai (:azakai)]

Attachment: patch

Currently the js console, when told to

  read('/usr/share/...')

will try to read

  CURRENT_DIR//user/share

(and fail) since it appends the parameter to the current directory.

Attached is a patch that leaves absolute pathnames (starting with '/') alone. For comparison, v8 does that.

Comment 1

[Alon Zakai (:azakai)]

Attachment: patch with context

(forgot -U 8, sorry)

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 555903 [details] [diff] [review]
patch with context

Review of attachment 555903 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +3805,5 @@
>  
> +    if (*leaf == '/') {
> +        /* We were given an absolute pathname. */
> +        return JS_strdup(cx, leaf);
> +    }

Do we want to wrap this in an |#if !defined(XP_WIN)|?

Comment 3

[Alon Zakai (:azakai)]

MakeAbsolutePathname is actually only defined and used ifdef XP_UNIX. I guess no one uses the shell on Windows ;)

Comment 4

[Alon Zakai (:azakai)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5a7e488482a5

Comment 5

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/5a7e488482a5