Closed
Bug 682216
Opened 13 years ago
Closed 10 years ago
Memory reporters for WebM-related allocations
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: kinetik, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file)
4.42 KB,
patch
|
n.nethercote
:
review+
kinetik
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #682215 +++ libnestegg will need to be modified to allow some form of allocator hooking, then the same approach to that used in bug 677653 can be used.
Reporter | ||
Updated•13 years ago
|
Whiteboard: [MemShrink]
Updated•13 years ago
|
Assignee: nobody → kinetik
Whiteboard: [MemShrink] → [MemShrink:P2]
Reporter | ||
Updated•11 years ago
|
Assignee: kinetik → nobody
Assignee | ||
Comment 1•10 years ago
|
||
Functional interface for setting libnestegg's allocator posted at https://github.com/kinetiknz/nestegg/pull/19 Once we agree on the interface, we can see about updating the in-tree copy, and then layering memory reporting on top of that.
Reporter | ||
Comment 2•10 years ago
|
||
Thanks for the pull request, I've just merged it. Apologies for the delay; I've been on leave.
Assignee | ||
Comment 3•10 years ago
|
||
Requires bug 992955, but nothing too complicated here.
Attachment #8403328 -
Flags: review?(n.nethercote)
Attachment #8403328 -
Flags: review?(kinetik)
Reporter | ||
Updated•10 years ago
|
Attachment #8403328 -
Flags: review?(kinetik) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8403328 [details] [diff] [review] add a memory reporter for libnestegg's memory Review of attachment 8403328 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/build/nsXPComInit.cpp @@ +572,5 @@ > + > + static void* Realloc(void* p, size_t size) > + { > + sAmount -= MallocSizeOfOnFree(p); > + void *pnew = realloc(p, size); Nit: '*' on the left.
Attachment #8403328 -
Flags: review?(n.nethercote) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c509bb6f5c4
Flags: in-testsuite-
Assignee | ||
Comment 6•10 years ago
|
||
Commited with changing things to use CountingAllocatorBase.
Assignee: nobody → nfroyd
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c509bb6f5c4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•