682216 - Memory reporters for WebM-related allocations

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

+++ This bug was initially created as a clone of Bug #682215 +++

libnestegg will need to be modified to allow some form of allocator hooking, then the same approach to that used in bug 677653 can be used.

Comment 1

[Nathan Froyd [:froydnj]]

Functional interface for setting libnestegg's allocator posted at https://github.com/kinetiknz/nestegg/pull/19

Once we agree on the interface, we can see about updating the in-tree copy, and then layering memory reporting on top of that.

Comment 2

[Matthew Gregan [:kinetik]]

Thanks for the pull request, I've just merged it.  Apologies for the delay; I've been on leave.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: add a memory reporter for libnestegg's memory

Requires bug 992955, but nothing too complicated here.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8403328 [details] [diff] [review]
add a memory reporter for libnestegg's memory

Review of attachment 8403328 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/build/nsXPComInit.cpp
@@ +572,5 @@
> +
> +    static void* Realloc(void* p, size_t size)
> +    {
> +        sAmount -= MallocSizeOfOnFree(p);
> +        void *pnew = realloc(p, size);

Nit: '*' on the left.

Comment 5

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c509bb6f5c4

Comment 6

[Nathan Froyd [:froydnj]]

Commited with changing things to use CountingAllocatorBase.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c509bb6f5c4