telemetry for IA2 deprecated methods

RESOLVED FIXED in mozilla10

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: surkov, Assigned: tbsaunde)

Tracking

({access})

unspecified
mozilla10
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
similar to bug 679786
(Assignee)

Comment 1

6 years ago
(In reply to alexander surkov from comment #0)
> similar to bug 679786

I'm not sure exactly what methods these are, and I suspect by the time you've listed them you'll hav written 75% of the patch ;)  so do you want to take this?
(Reporter)

Comment 2

6 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> I'm not sure exactly what methods these are, and I suspect by the time
> you've listed them you'll hav written 75% of the patch ;)  so do you want to
> take this?

that's correct, not this minute, marking it as good first bug hoping that someone would willing to work on it

iirc only IAccessibleTable is deprecated now, so the patch should telemetry when this interface is queried
Whiteboard: [good first bug]
(Assignee)

Comment 3

6 years ago
Created attachment 562478 [details] [diff] [review]
patch
Attachment #562478 - Flags: review?(surkov.alexander)
(Reporter)

Comment 4

6 years ago
Comment on attachment 562478 [details] [diff] [review]
patch

Review of attachment 562478 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/Statistics.h
@@ +55,5 @@
>    inline void ISimpleDomUsed()
>    { Telemetry::Accumulate(Telemetry::ISIMPLE_DOM_USAGE, 1); }
>  
> +  /**
> +   * Report that IAccessibleTable has been used.

please add deprecated word

@@ +58,5 @@
> +  /**
> +   * Report that IAccessibleTable has been used.
> +   */
> +  inline void IAccessibleTableUsed()
> +  { Telemetry::Accumulate(Telemetry::IACCESSIBLE_TABLE_USAGE, 1); }

two space indentation of function body

::: toolkit/components/telemetry/TelemetryHistograms.h
@@ +54,4 @@
>   */
>  HISTOGRAM(A11Y_INSTANTIATED, 0, 1, 2, BOOLEAN, "has accessibility support been instantiated")
>  HISTOGRAM(ISIMPLE_DOM_USAGE, 0, 1, 2, BOOLEAN, "have the ISimpleDOM* accessibility interfaces been used")
> +HISTOGRAM(IACCESSIBLE_TABLE_USAGE, 0, 1, 2, BOOLEAN, "has the IAccessibleTable accessibility interface been used")

add deprecated word please
Attachment #562478 - Flags: review?(surkov.alexander) → review+
(Reporter)

Updated

6 years ago
Assignee: nobody → trev.saunders
(Assignee)

Comment 5

6 years ago
Created attachment 562766 [details] [diff] [review]
patch v3
(Assignee)

Comment 6

6 years ago
inbound  http://hg.mozilla.org/integration/mozilla-inbound/rev/7019803376f1
https://hg.mozilla.org/mozilla-central/rev/7019803376f1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.