Last Comment Bug 682247 - telemetry for IA2 deprecated methods
: telemetry for IA2 deprecated methods
Status: RESOLVED FIXED
[good first bug]
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Trevor Saunders (:tbsaunde)
:
: alexander :surkov
Mentors:
Depends on:
Blocks: telemetrya11y
  Show dependency treegraph
 
Reported: 2011-08-26 03:39 PDT by alexander :surkov
Modified: 2011-09-30 07:31 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.33 KB, patch)
2011-09-26 10:45 PDT, Trevor Saunders (:tbsaunde)
surkov.alexander: review+
Details | Diff | Splinter Review
patch v3 (2.38 KB, patch)
2011-09-27 07:52 PDT, Trevor Saunders (:tbsaunde)
no flags Details | Diff | Splinter Review

Description alexander :surkov 2011-08-26 03:39:17 PDT
similar to bug 679786
Comment 1 Trevor Saunders (:tbsaunde) 2011-08-26 06:11:35 PDT
(In reply to alexander surkov from comment #0)
> similar to bug 679786

I'm not sure exactly what methods these are, and I suspect by the time you've listed them you'll hav written 75% of the patch ;)  so do you want to take this?
Comment 2 alexander :surkov 2011-08-28 23:53:04 PDT
(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> I'm not sure exactly what methods these are, and I suspect by the time
> you've listed them you'll hav written 75% of the patch ;)  so do you want to
> take this?

that's correct, not this minute, marking it as good first bug hoping that someone would willing to work on it

iirc only IAccessibleTable is deprecated now, so the patch should telemetry when this interface is queried
Comment 3 Trevor Saunders (:tbsaunde) 2011-09-26 10:45:17 PDT
Created attachment 562478 [details] [diff] [review]
patch
Comment 4 alexander :surkov 2011-09-26 20:12:38 PDT
Comment on attachment 562478 [details] [diff] [review]
patch

Review of attachment 562478 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/Statistics.h
@@ +55,5 @@
>    inline void ISimpleDomUsed()
>    { Telemetry::Accumulate(Telemetry::ISIMPLE_DOM_USAGE, 1); }
>  
> +  /**
> +   * Report that IAccessibleTable has been used.

please add deprecated word

@@ +58,5 @@
> +  /**
> +   * Report that IAccessibleTable has been used.
> +   */
> +  inline void IAccessibleTableUsed()
> +  { Telemetry::Accumulate(Telemetry::IACCESSIBLE_TABLE_USAGE, 1); }

two space indentation of function body

::: toolkit/components/telemetry/TelemetryHistograms.h
@@ +54,4 @@
>   */
>  HISTOGRAM(A11Y_INSTANTIATED, 0, 1, 2, BOOLEAN, "has accessibility support been instantiated")
>  HISTOGRAM(ISIMPLE_DOM_USAGE, 0, 1, 2, BOOLEAN, "have the ISimpleDOM* accessibility interfaces been used")
> +HISTOGRAM(IACCESSIBLE_TABLE_USAGE, 0, 1, 2, BOOLEAN, "has the IAccessibleTable accessibility interface been used")

add deprecated word please
Comment 5 Trevor Saunders (:tbsaunde) 2011-09-27 07:52:09 PDT
Created attachment 562766 [details] [diff] [review]
patch v3
Comment 6 Trevor Saunders (:tbsaunde) 2011-09-29 18:16:37 PDT
inbound  http://hg.mozilla.org/integration/mozilla-inbound/rev/7019803376f1

Note You need to log in before you can comment on or make changes to this bug.