682247 - telemetry for IA2 deprecated methods

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

similar to bug 679786

Comment 1

[Trevor Saunders (:tbsaunde)]

(In reply to alexander surkov from comment #0)
> similar to bug 679786

I'm not sure exactly what methods these are, and I suspect by the time you've listed them you'll hav written 75% of the patch ;)  so do you want to take this?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> I'm not sure exactly what methods these are, and I suspect by the time
> you've listed them you'll hav written 75% of the patch ;)  so do you want to
> take this?

that's correct, not this minute, marking it as good first bug hoping that someone would willing to work on it

iirc only IAccessibleTable is deprecated now, so the patch should telemetry when this interface is queried

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: patch

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 562478 [details] [diff] [review]
patch

Review of attachment 562478 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/Statistics.h
@@ +55,5 @@
>    inline void ISimpleDomUsed()
>    { Telemetry::Accumulate(Telemetry::ISIMPLE_DOM_USAGE, 1); }
>  
> +  /**
> +   * Report that IAccessibleTable has been used.

please add deprecated word

@@ +58,5 @@
> +  /**
> +   * Report that IAccessibleTable has been used.
> +   */
> +  inline void IAccessibleTableUsed()
> +  { Telemetry::Accumulate(Telemetry::IACCESSIBLE_TABLE_USAGE, 1); }

two space indentation of function body

::: toolkit/components/telemetry/TelemetryHistograms.h
@@ +54,4 @@
>   */
>  HISTOGRAM(A11Y_INSTANTIATED, 0, 1, 2, BOOLEAN, "has accessibility support been instantiated")
>  HISTOGRAM(ISIMPLE_DOM_USAGE, 0, 1, 2, BOOLEAN, "have the ISimpleDOM* accessibility interfaces been used")
> +HISTOGRAM(IACCESSIBLE_TABLE_USAGE, 0, 1, 2, BOOLEAN, "has the IAccessibleTable accessibility interface been used")

add deprecated word please

Comment 5

[Trevor Saunders (:tbsaunde)]

Attachment: patch v3

Comment 6

[Trevor Saunders (:tbsaunde)]

inbound  http://hg.mozilla.org/integration/mozilla-inbound/rev/7019803376f1

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7019803376f1