682319 - use C99 isfinite() on OS X

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(not currently active) Ted Mielczarek]

math.h in the OS X SDK says about finite:
/* Legacy API: please use C99 isfinite() instead. */

It's not present in the iOS SDK. I'm not sure if it's safe to totally replace finite with isfinite, since the latter is C99, and glibc might not make it available in non-C99 mode. My patch just uses it on OS X, where it should always be available.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: use C99 isfinite on OS X, since finite is deprecated (and not present on iOS)

This builds fine for me on iOS and OS X.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 556057 [details] [diff] [review]
use C99 isfinite on OS X, since finite is deprecated (and not present on iOS)

This seems fine, though a comment explaining why might be nice.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: use C99 isfinite on OS X, since finite is deprecated (and not present on iOS).

Updated patch. I changed the #define around and added a comment.

Comment 4

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/projects/build-system/rev/80b591f7b135

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/80b591f7b135