use C99 isfinite() on OS X

RESOLVED FIXED in mozilla9

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
mozilla9
ARM
iOS 4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [iOS] fixed-in-bs)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
math.h in the OS X SDK says about finite:
/* Legacy API: please use C99 isfinite() instead. */

It's not present in the iOS SDK. I'm not sure if it's safe to totally replace finite with isfinite, since the latter is C99, and glibc might not make it available in non-C99 mode. My patch just uses it on OS X, where it should always be available.
(Assignee)

Updated

6 years ago
Whiteboard: [iOS]
(Assignee)

Comment 1

6 years ago
Created attachment 556057 [details] [diff] [review]
use C99 isfinite on OS X, since finite is deprecated (and not present on iOS)

This builds fine for me on iOS and OS X.
Attachment #556057 - Flags: review?(bzbarsky)
Comment on attachment 556057 [details] [diff] [review]
use C99 isfinite on OS X, since finite is deprecated (and not present on iOS)

This seems fine, though a comment explaining why might be nice.
Attachment #556057 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 556109 [details] [diff] [review]
use C99 isfinite on OS X, since finite is deprecated (and not present on iOS).

Updated patch. I changed the #define around and added a comment.
(Assignee)

Updated

6 years ago
Attachment #556057 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/projects/build-system/rev/80b591f7b135
Whiteboard: [iOS] → [iOS] fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/80b591f7b135
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.