Closed
Bug 682319
Opened 14 years ago
Closed 14 years ago
use C99 isfinite() on OS X
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: ted, Assigned: ted)
Details
(Whiteboard: [iOS] fixed-in-bs)
Attachments
(1 file, 1 obsolete file)
math.h in the OS X SDK says about finite:
/* Legacy API: please use C99 isfinite() instead. */
It's not present in the iOS SDK. I'm not sure if it's safe to totally replace finite with isfinite, since the latter is C99, and glibc might not make it available in non-C99 mode. My patch just uses it on OS X, where it should always be available.
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [iOS]
|
|
Assignee | |
Comment 1•14 years ago
|
||
This builds fine for me on iOS and OS X.
Attachment #556057 -
Flags: review?(bzbarsky)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 556057 [details] [diff] [review]
use C99 isfinite on OS X, since finite is deprecated (and not present on iOS)
This seems fine, though a comment explaining why might be nice.
Attachment #556057 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Updated patch. I changed the #define around and added a comment.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #556057 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: [iOS] → [iOS] fixed-in-bs
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•