682324 - Sisyphus - webapp - markup characters need to be escaped in output

Status: RESOLVED FIXED

(Testing Graveyard :: Sisyphus, defect)

Description

[Bob Clary [:bc] (inactive)]

In the #crashes view and possibly others, some output will contain what appear to be tags. For example, the signature:

nsCOMPtr<nsINodeInfo>::get() | nsINode::GetOwnerDoc() nsINode::GetCurrentDoc() nsGenericElement::UnbindFromTree(int, int) nsXMLElement::UnbindFromTree(int, int) nsGenericElement::UnbindFromTree(int, int)

This is currently displayed in the crashes by date view as:

nsCOMPtr::operator->() | nsIContent::IsInNamespace(int) nsIContent::IsXUL() nsXULElement::FromContent(nsIContent*) nsGenericElement::UnbindFromTree(int, int) nsXMLElement::UnbindFromTree(int, int)

When displaying content from the database, markup sensitive characters such as    < > " ' \ & should be replaced by their entity equivalents.

Comment 1

[Mark Côté [:mcote]]

Attachment: Escape data taken from database. Improve log formatting.

Escape data taken from database. Improve log formatting.

Comment 2

[Bob Clary [:bc] (inactive)]

Comment on attachment 556133 [details] [diff] [review]
Escape data taken from database. Improve log formatting.

r+ but I would like to change the layout for the logs so that the log date is a fixed width instead of a percentage and the log machine to prevent the machine name from bleeding into the message column for long machine names such as valgrind1.sandbox.sjc1.mozilla.com.

Comment 3

[Bob Clary [:bc] (inactive)]

https://hg.mozilla.org/automation/sisyphus/rev/138437198029