Closed
Bug 682324
Opened 13 years ago
Closed 13 years ago
Sisyphus - webapp - markup characters need to be escaped in output
Categories
(Testing Graveyard :: Sisyphus, defect)
Testing Graveyard
Sisyphus
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Unassigned)
References
Details
Attachments
(1 file)
7.99 KB,
patch
|
bc
:
review+
jeads
:
feedback+
|
Details | Diff | Splinter Review |
In the #crashes view and possibly others, some output will contain what appear to be tags. For example, the signature: nsCOMPtr<nsINodeInfo>::get() | nsINode::GetOwnerDoc() nsINode::GetCurrentDoc() nsGenericElement::UnbindFromTree(int, int) nsXMLElement::UnbindFromTree(int, int) nsGenericElement::UnbindFromTree(int, int) This is currently displayed in the crashes by date view as: nsCOMPtr::operator->() | nsIContent::IsInNamespace(int) nsIContent::IsXUL() nsXULElement::FromContent(nsIContent*) nsGenericElement::UnbindFromTree(int, int) nsXMLElement::UnbindFromTree(int, int) When displaying content from the database, markup sensitive characters such as < > " ' \ & should be replaced by their entity equivalents.
Comment 1•13 years ago
|
||
Escape data taken from database. Improve log formatting.
Updated•13 years ago
|
Attachment #556133 -
Flags: review?(bclary)
Attachment #556133 -
Flags: feedback?(jeads)
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 556133 [details] [diff] [review] Escape data taken from database. Improve log formatting. r+ but I would like to change the layout for the logs so that the log date is a fixed width instead of a percentage and the log machine to prevent the machine name from bleeding into the message column for long machine names such as valgrind1.sandbox.sjc1.mozilla.com.
Attachment #556133 -
Flags: review?(bclary) → review+
Reporter | ||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/automation/sisyphus/rev/138437198029
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment #556133 -
Flags: feedback?(jeads) → feedback+
Updated•5 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•