Closed
Bug 682326
Opened 13 years ago
Closed 13 years ago
Disable method jit for chrome
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox7 fixed, firefox8 fixed, firefox9 fixed)
RESOLVED
FIXED
Firefox 7
People
(Reporter: mfinkle, Unassigned)
Details
(Keywords: addon-compat, Whiteboard: [qa-])
Attachments
(1 file)
2.30 KB,
patch
|
mbrubeck
:
review+
christian
:
approval-mozilla-aurora+
christian
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
When we turned on method jit for chrome, we didn't really see that much of a gain in performance, if any. But we are using more memory in the parent process because of it. This patch turns off methodjit for chrome. You will still see some parent process mjit usage in about:memory because some webpage (content) are loaded in the parent process.
Attachment #556061 -
Flags: review?(mbrubeck)
Comment 1•13 years ago
|
||
Comment on attachment 556061 [details] [diff] [review] patch Review of attachment 556061 [details] [diff] [review]: ----------------------------------------------------------------- Don't check in the mozconfig.
Attachment #556061 -
Flags: review?(mbrubeck) → review+
Reporter | ||
Comment 2•13 years ago
|
||
removed the mozconfig and actually set the pref to false http://hg.mozilla.org/integration/mozilla-inbound/rev/60594ddf3d9e
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/60594ddf3d9e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 556061 [details] [diff] [review] patch To help reduce memory usage
Attachment #556061 -
Flags: approval-mozilla-beta?
Attachment #556061 -
Flags: approval-mozilla-aurora?
Comment 5•13 years ago
|
||
I second the aurora/beta nominations. The method JIT uses a lot of memory. And it should be very low-risk, since it was off previously.
Comment on attachment 556061 [details] [diff] [review] patch Approved for releases/mozilla-aurora and releases/mozilla-beta. Please land asap.
Attachment #556061 -
Flags: approval-mozilla-beta?
Attachment #556061 -
Flags: approval-mozilla-beta+
Attachment #556061 -
Flags: approval-mozilla-aurora?
Attachment #556061 -
Flags: approval-mozilla-aurora+
Reporter | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/b1d382004d3f http://hg.mozilla.org/releases/mozilla-beta/rev/12bfaef14a35
status-firefox7:
--- → fixed
status-firefox8:
--- → fixed
status-firefox9:
--- → fixed
Target Milestone: Firefox 9 → Firefox 7
Is there a bug on file for doing this on desktop firefox?
Reporter | ||
Comment 9•13 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #8) > Is there a bug on file for doing this on desktop firefox? Not that I am aware of, but desktop might have different behavior/goals. It's a tradeoff and on mobile we traded for memory.
Comment 10•13 years ago
|
||
I'm worried this change will make computationally intensive add-ons much slower. Why was this solution chosen as opposed to, say, tweaking the method jit heuristics to kick in less often?
Updated•13 years ago
|
Keywords: addon-compat
Are people running computationally intensive addons on mobile? Also, there's still the tracer, right?
Reporter | ||
Comment 12•13 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #11) > Are people running computationally intensive addons on mobile? It's possible I guess > Also, there's still the tracer, right? Yes, the tracer is still enabled
Comment 13•13 years ago
|
||
The tracer is disabled by default. Does disabling the method jit actually enable the tracer? How long until the tracer is ripped out?
Comment 15•13 years ago
|
||
I think the mjit's problem here is in its technique for discarding jitcode. Stock JM occasionally tries to discard jitcode during GC, but can only do so if the jitcode's compartment does not have active frames on the stack. I noticed when fixing bug 688292 that when we GC there is almost always chrome code on the stack (at least on some workloads), which will cause mjit code to be discarded even slower. In compartments with TI enabled (not chrome) this is different, and all jitcode is discarded on every GC even in compartments with frames on the stack. I tried to do this for stock JM too in bug 685358, but ran into problems with JM+TM integration (weird corruption problems). By removing the tracer or decoupling it from JM, that bug could reland.
You need to log in
before you can comment on or make changes to this bug.
Description
•