682327 - ASSERTION: Failed to make GL context current!: 'succeeded' GLContextProviderEGL.cpp, line 795

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

Ok, problem seems to be caused by 
http://hg.mozilla.org/mozilla-central/rev/6e7449c449ba#l2.33
we should not check mSurface on Qt port.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Move surface check before MakeCurrent conditions

Comment 2

[Ali Juma [:ajuma]]

Comment on attachment 556066 [details] [diff] [review]
Move surface check before MakeCurrent conditions

Review of attachment 556066 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, with a small fix needed.

::: gfx/thebes/GLContextProviderEGL.cpp
@@ +785,4 @@
>  #ifndef MOZ_WIDGET_QT
> +        if (!mSurface) {
> +            EGLConfig config = CreateConfig();
> +            mSurface = CreateSurfaceForWindow(NULL, config);

We still need a call to fMakeCurrent when we create a new surface. So add the line:

aForce = PR_TRUE;

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Fixed comment, to PUSH

Comment 4

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c62371f0112a

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/c62371f0112a