ASSERTION: Failed to make GL context current!: 'succeeded' GLContextProviderEGL.cpp, line 795

RESOLVED FIXED in mozilla9

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
6 years ago
11 months ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla9
ARM
Maemo
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Ok, problem seems to be caused by 
http://hg.mozilla.org/mozilla-central/rev/6e7449c449ba#l2.33
we should not check mSurface on Qt port.
(Assignee)

Comment 1

6 years ago
Created attachment 556066 [details] [diff] [review]
Move surface check before MakeCurrent conditions
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #556066 - Flags: review?(matt.woodrow)
(Assignee)

Updated

6 years ago
Blocks: 677920, 677712

Comment 2

6 years ago
Comment on attachment 556066 [details] [diff] [review]
Move surface check before MakeCurrent conditions

Review of attachment 556066 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, with a small fix needed.

::: gfx/thebes/GLContextProviderEGL.cpp
@@ +785,4 @@
>  #ifndef MOZ_WIDGET_QT
> +        if (!mSurface) {
> +            EGLConfig config = CreateConfig();
> +            mSurface = CreateSurfaceForWindow(NULL, config);

We still need a call to fMakeCurrent when we create a new surface. So add the line:

aForce = PR_TRUE;
Attachment #556066 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 556154 [details] [diff] [review]
Fixed comment, to PUSH
Attachment #556066 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/c62371f0112a
Keywords: checkin-needed
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/c62371f0112a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.