682367 - Call nsINode::GetChildAt less

Status: RESOLVED FIXED

Description

[David Zbarsky (:dzbarsky)]

Comment 1

[David Zbarsky (:dzbarsky)]

Created attachment 556231 [details] [diff] [review]
content/ patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 556231 [details] [diff] [review]
content/ patch

>--- a/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
>+++ b/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
> GetFirstMpathChild(nsIContent* aElem)

>+  for (nsIContent* child = aElem->GetFirstChild();
>+         child;
>+         child = child->GetNextSibling()) {

Indentation is off.

Comment 3

[David Zbarsky (:dzbarsky)]

Created attachment 556275 [details] [diff] [review]
content/ patch

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 556275 [details] [diff] [review]
content/ patch

Olli, could you take this review.

David: One comment is that it should be possible to change nsContentIterator to not use GetChildAt *at all*, and instead use GetFirstChild/GetNextSibling/etc to do all its iteration. This would let you get rid of the array of indexes as well.

It's probably better to do that as a separate patch though.

Comment 5

[Olli Pettay [:smaug] (high review load)]

Comment on attachment 556275 [details] [diff] [review]
content/ patch


>-static void
>-GetImmediateChild(nsIContent* aContent, nsIAtom *aTag, nsIContent** aResult) 
>+static already_AddRefed<nsIContent>
>+GetImmediateChild(nsIContent* aContent, nsIAtom *aTag) 
This is unrelated change, but ok.

Comment 6

[David Zbarsky (:dzbarsky)]

Created attachment 562543 [details] [diff] [review]
content/ patch r=smaug

Comment 7

[Dão Gottwald [::dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80ff402f2f7e

Comment 8

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

https://hg.mozilla.org/mozilla-central/rev/80ff402f2f7e