Closed
Bug 682367
Opened 14 years ago
Closed 14 years ago
Call nsINode::GetChildAt less
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(1 file, 2 obsolete files)
73.71 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → dzbarsky
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #556231 -
Flags: review?(jonas)
Comment 2•14 years ago
|
||
Comment on attachment 556231 [details] [diff] [review]
content/ patch
>--- a/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
>+++ b/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
> GetFirstMpathChild(nsIContent* aElem)
>+ for (nsIContent* child = aElem->GetFirstChild();
>+ child;
>+ child = child->GetNextSibling()) {
Indentation is off.
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #556231 -
Attachment is obsolete: true
Attachment #556231 -
Flags: review?(jonas)
Attachment #556275 -
Flags: review?(jonas)
Comment on attachment 556275 [details] [diff] [review]
content/ patch
Olli, could you take this review.
David: One comment is that it should be possible to change nsContentIterator to not use GetChildAt *at all*, and instead use GetFirstChild/GetNextSibling/etc to do all its iteration. This would let you get rid of the array of indexes as well.
It's probably better to do that as a separate patch though.
Attachment #556275 -
Flags: review?(jonas) → review?(Olli.Pettay)
Comment 5•14 years ago
|
||
Comment on attachment 556275 [details] [diff] [review]
content/ patch
>-static void
>-GetImmediateChild(nsIContent* aContent, nsIAtom *aTag, nsIContent** aResult)
>+static already_AddRefed<nsIContent>
>+GetImmediateChild(nsIContent* aContent, nsIAtom *aTag)
This is unrelated change, but ok.
Attachment #556275 -
Flags: review?(Olli.Pettay) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #556275 -
Attachment is obsolete: true
Attachment #562543 -
Flags: checkin?
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 7•14 years ago
|
||
Keywords: checkin-needed
Updated•14 years ago
|
Attachment #562543 -
Flags: checkin?
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•