The default bug view has changed. See this FAQ.

Rename nsINode::GetOwnerDoc to nsINode::OwnerDoc

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
.
(Assignee)

Updated

6 years ago
Assignee: nobody → Olli.Pettay
(Assignee)

Comment 1

6 years ago
Created attachment 567366 [details] [diff] [review]
initial patch

...but I think I should remove some unneeded null checks while I'm changing the
code.
(Assignee)

Comment 2

6 years ago
Created attachment 567405 [details] [diff] [review]
s/GetOwnerDoc()/OwnerDoc()/

This is script generated patch, but I had to fix few whitespace issues manually
when the change was done inside a macro.

Another patch coming which will remove some null checks.
Attachment #567366 - Attachment is obsolete: true
Attachment #567405 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #567405 - Flags: review? → review?(jst)
(Assignee)

Comment 3

6 years ago
Created attachment 567429 [details] [diff] [review]
Remove useless null checks

Uploaded to try.

There can be still some more useless null checks, but this should cover
most common cases.
Attachment #567429 - Flags: review?(jst)
(Assignee)

Comment 4

6 years ago
Created attachment 567430 [details] [diff] [review]
-w

Updated

6 years ago
Attachment #567405 - Flags: review?(jst) → review+

Updated

6 years ago
Attachment #567429 - Flags: review?(jst) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 567704 [details] [diff] [review]
s/GetOwnerDoc()/OwnerDoc()/, up-to-date

s/PR_TRUE/true/ patch caused quite a few merging problems.
(Assignee)

Comment 6

6 years ago
Created attachment 567707 [details] [diff] [review]
Remove useless null checks, up-to-date
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/9e6aa5ee6425
https://hg.mozilla.org/mozilla-central/rev/41a01f78db7a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

5 years ago
Created attachment 580695 [details] [diff] [review]
backout for 10, part 1

Just in case we want to backout strong parent node from 10...
(Assignee)

Comment 9

5 years ago
Created attachment 580700 [details] [diff] [review]
backout for 10, part 2
(Assignee)

Comment 10

5 years ago
Created attachment 580732 [details] [diff] [review]
backout strongparent node from 10

This patch is really not for this bug, but want to back it up somewhere.
And it is needed if we want to have non-strong-parent in 10.
Blocks: 751422
No longer blocks: 751422
Depends on: 751422
You need to log in before you can comment on or make changes to this bug.