Last Comment Bug 682420 - Rename nsINode::GetOwnerDoc to nsINode::OwnerDoc
: Rename nsINode::GetOwnerDoc to nsINode::OwnerDoc
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (TPAC)
:
Mentors:
Depends on: 675166 CVE-2012-1944
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-26 14:33 PDT by Olli Pettay [:smaug] (TPAC)
Modified: 2012-05-02 19:45 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
initial patch (287.28 KB, patch)
2011-10-16 16:45 PDT, Olli Pettay [:smaug] (TPAC)
no flags Details | Diff | Splinter Review
s/GetOwnerDoc()/OwnerDoc()/ (289.11 KB, patch)
2011-10-17 02:10 PDT, Olli Pettay [:smaug] (TPAC)
jst: review+
Details | Diff | Splinter Review
Remove useless null checks (125.29 KB, patch)
2011-10-17 05:55 PDT, Olli Pettay [:smaug] (TPAC)
jst: review+
Details | Diff | Splinter Review
-w (116.06 KB, patch)
2011-10-17 05:55 PDT, Olli Pettay [:smaug] (TPAC)
no flags Details | Diff | Splinter Review
s/GetOwnerDoc()/OwnerDoc()/, up-to-date (288.63 KB, patch)
2011-10-18 03:51 PDT, Olli Pettay [:smaug] (TPAC)
no flags Details | Diff | Splinter Review
Remove useless null checks, up-to-date (125.17 KB, patch)
2011-10-18 04:19 PDT, Olli Pettay [:smaug] (TPAC)
no flags Details | Diff | Splinter Review
backout for 10, part 1 (124.35 KB, patch)
2011-12-10 15:50 PST, Olli Pettay [:smaug] (TPAC)
no flags Details | Diff | Splinter Review
backout for 10, part 2 (294.56 KB, patch)
2011-12-10 16:42 PST, Olli Pettay [:smaug] (TPAC)
no flags Details | Diff | Splinter Review
backout strongparent node from 10 (21.33 KB, patch)
2011-12-11 05:24 PST, Olli Pettay [:smaug] (TPAC)
no flags Details | Diff | Splinter Review

Description Olli Pettay [:smaug] (TPAC) 2011-08-26 14:33:01 PDT
.
Comment 1 Olli Pettay [:smaug] (TPAC) 2011-10-16 16:45:05 PDT
Created attachment 567366 [details] [diff] [review]
initial patch

...but I think I should remove some unneeded null checks while I'm changing the
code.
Comment 2 Olli Pettay [:smaug] (TPAC) 2011-10-17 02:10:22 PDT
Created attachment 567405 [details] [diff] [review]
s/GetOwnerDoc()/OwnerDoc()/

This is script generated patch, but I had to fix few whitespace issues manually
when the change was done inside a macro.

Another patch coming which will remove some null checks.
Comment 3 Olli Pettay [:smaug] (TPAC) 2011-10-17 05:55:01 PDT
Created attachment 567429 [details] [diff] [review]
Remove useless null checks

Uploaded to try.

There can be still some more useless null checks, but this should cover
most common cases.
Comment 4 Olli Pettay [:smaug] (TPAC) 2011-10-17 05:55:24 PDT
Created attachment 567430 [details] [diff] [review]
-w
Comment 5 Olli Pettay [:smaug] (TPAC) 2011-10-18 03:51:38 PDT
Created attachment 567704 [details] [diff] [review]
s/GetOwnerDoc()/OwnerDoc()/, up-to-date

s/PR_TRUE/true/ patch caused quite a few merging problems.
Comment 6 Olli Pettay [:smaug] (TPAC) 2011-10-18 04:19:47 PDT
Created attachment 567707 [details] [diff] [review]
Remove useless null checks, up-to-date
Comment 8 Olli Pettay [:smaug] (TPAC) 2011-12-10 15:50:59 PST
Created attachment 580695 [details] [diff] [review]
backout for 10, part 1

Just in case we want to backout strong parent node from 10...
Comment 9 Olli Pettay [:smaug] (TPAC) 2011-12-10 16:42:28 PST
Created attachment 580700 [details] [diff] [review]
backout for 10, part 2
Comment 10 Olli Pettay [:smaug] (TPAC) 2011-12-11 05:24:57 PST
Created attachment 580732 [details] [diff] [review]
backout strongparent node from 10

This patch is really not for this bug, but want to back it up somewhere.
And it is needed if we want to have non-strong-parent in 10.

Note You need to log in before you can comment on or make changes to this bug.