Created attachment 556167 [details] testcase ###!!! ASSERTION: potential leak, plus waste of work: 'mTableInheritedAttributes == TABLE_ATTRS_DIRTY', file content/html/content/src/nsHTMLTableElement.cpp, line 1228 + trace-refcnt reports a leaked "nsMappedAttributes" object
Using nsHTMLTableElement::SetAttr is just buggy
Yes, bug 211636 should have used Before/AfterSetAttr, not override SetAttr.
Olli, are you fixing this? Or is Bernd? Requesting tracking for the leak regression.
tracking-firefox9: --- → ?
I don't feel comfortable with this, see https://bugzilla.mozilla.org/show_bug.cgi?id=211636#c9 >I am insecure about the changes in SetAttr and UnsetAttr
Created attachment 556252 [details] [diff] [review] Patch v1 Something like this? (Untested)
Attachment #556252 - Flags: review?(Olli.Pettay)
Attachment #556252 - Flags: review?(Olli.Pettay) → review+
Try run for edb5c7975703 is complete. Detailed breakdown of the results available here: http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=edb5c7975703 Results (out of 229 total builds): success: 212 warnings: 15 failure: 2 Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/Ms2ger@gmail.com-edb5c7975703
Created attachment 556383 [details] [diff] [review] Patch for checkin As suggested by Bernd, fixed bug 211636 comment 16 as well. Ed, if you don't mind? (Passed try: <http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=edb5c7975703>)
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla9
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.