Closed Bug 682460 Opened 10 years ago Closed 10 years ago

Leak when forcing layout during mutation event for table attribute

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: jruderman, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, memory-leak, regression)

Attachments

(3 files, 1 obsolete file)

Attached file testcase
###!!! ASSERTION: potential leak, plus waste of work: 'mTableInheritedAttributes == TABLE_ATTRS_DIRTY', file content/html/content/src/nsHTMLTableElement.cpp, line 1228

+ trace-refcnt reports a leaked "nsMappedAttributes" object
Attached file stack trace
Using nsHTMLTableElement::SetAttr is just buggy
I think this is a regression from bug 211636
Depends on: 211636
Yes, bug 211636 should have used Before/AfterSetAttr, not override SetAttr.
Blocks: 211636
No longer depends on: 211636
Keywords: regression
Olli, are you fixing this?  Or is Bernd?

Requesting tracking for the leak regression.
I don't feel comfortable with this, see https://bugzilla.mozilla.org/show_bug.cgi?id=211636#c9 
>I am insecure about the changes in SetAttr and UnsetAttr
Attached patch Patch v1 (obsolete) — Splinter Review
Something like this? (Untested)
Attachment #556252 - Flags: review?(Olli.Pettay)
Attachment #556252 - Flags: review?(Olli.Pettay) → review+
Try run for edb5c7975703 is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=edb5c7975703
Results (out of 229 total builds):
    success: 212
    warnings: 15
    failure: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/Ms2ger@gmail.com-edb5c7975703
As suggested by Bernd, fixed bug 211636 comment 16 as well. Ed, if you don't mind? (Passed try: <http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=edb5c7975703>)
Assignee: nobody → Ms2ger
Attachment #556252 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #556383 - Flags: checkin?(bmo)
http://hg.mozilla.org/integration/mozilla-inbound/rev/f1cf848b1ff2
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla9
Attachment #556383 - Flags: checkin?(bmo) → checkin+
http://hg.mozilla.org/mozilla-central/rev/f1cf848b1ff2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.