682606 - Feed processing hangs on non handling of a malformed enclosure url within a single item.

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[alta88]

Attachment: patch

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 556299 [details] [diff] [review]
patch

Can you provide a testcase for this? It'll help with testing the patch.

Thanks.

Comment 2

[alta88]

for example, this feed url:
http://www.zerohedge.com/fullrss2.xml

currently has this tag within an <item>

<enclosure url="/images/user5/imageroot/2011/08/hmmm_august_26_2011_pdf_20055.pdf" length="1024771" type="application/pdf" />

is that sufficient?  or is some other form better?

Comment 3

[Mark Banner (:standard8)]

Attachment: Testcase

I made a testcase based on the example. With this I can reproduce easily - the processing does indeed stop.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 556299 [details] [diff] [review]
patch

Yep, this looks good, thanks.

Comment 5

[alta88]

i think this just needs a checkin..

Comment 6

[Mark Banner (:standard8)]

(In reply to alta88 from comment #5)
> i think this just needs a checkin..

Adding checkin-needed to the keywords is the way to do that.

Comment 7

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/9c606884c53e

Comment 8

[Ludovic Hirlimann [:Usul]]

Alta88 would you be willing to add one unit test for this case, to make sure we don't regress in the future ?