Closed Bug 682606 Opened 8 years ago Closed 8 years ago

Feed processing hangs on non handling of a malformed enclosure url within a single item.

Categories

(MailNews Core :: Feed Reader, defect, major)

All
Windows 7
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 9.0

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(2 files)

Attached patch patchSplinter Review
No description provided.
Attachment #556299 - Flags: review?(mbanner)
Comment on attachment 556299 [details] [diff] [review]
patch

Can you provide a testcase for this? It'll help with testing the patch.

Thanks.
for example, this feed url:
http://www.zerohedge.com/fullrss2.xml

currently has this tag within an <item>

<enclosure url="/images/user5/imageroot/2011/08/hmmm_august_26_2011_pdf_20055.pdf" length="1024771" type="application/pdf" />

is that sufficient?  or is some other form better?
Attached file Testcase
I made a testcase based on the example. With this I can reproduce easily - the processing does indeed stop.
Assignee: nobody → alta88
Flags: in-testsuite?
Comment on attachment 556299 [details] [diff] [review]
patch

Yep, this looks good, thanks.
Attachment #556299 - Flags: review?(mbanner) → review+
i think this just needs a checkin..
(In reply to alta88 from comment #5)
> i think this just needs a checkin..

Adding checkin-needed to the keywords is the way to do that.
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/9c606884c53e
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
Alta88 would you be willing to add one unit test for this case, to make sure we don't regress in the future ?
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.