Closed Bug 682606 Opened 10 years ago Closed 10 years ago
Feed processing hangs on non handling of a malformed enclosure url within a single item
No description provided.
Attachment #556299 - Flags: review?(mbanner)
Comment on attachment 556299 [details] [diff] [review] patch Can you provide a testcase for this? It'll help with testing the patch. Thanks.
for example, this feed url: http://www.zerohedge.com/fullrss2.xml currently has this tag within an <item> <enclosure url="/images/user5/imageroot/2011/08/hmmm_august_26_2011_pdf_20055.pdf" length="1024771" type="application/pdf" /> is that sufficient? or is some other form better?
I made a testcase based on the example. With this I can reproduce easily - the processing does indeed stop.
Comment on attachment 556299 [details] [diff] [review] patch Yep, this looks good, thanks.
Attachment #556299 - Flags: review?(mbanner) → review+
i think this just needs a checkin..
(In reply to alta88 from comment #5) > i think this just needs a checkin.. Adding checkin-needed to the keywords is the way to do that.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
Alta88 would you be willing to add one unit test for this case, to make sure we don't regress in the future ?
You need to log in before you can comment on or make changes to this bug.