OOM crash in BasicPlanarYCbCrImage::SetData

RESOLVED FIXED in mozilla9

Status

()

Core
Graphics
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bjacob, Assigned: mattwoodrow)

Tracking

({crash, topcrash})

unspecified
mozilla9
x86
Linux
crash, topcrash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

This is the 6th top crasher on Firefox 8.0a2 on Linux with 4 crashes last week on 2 different machines/distros, including one on Ubuntu.

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A8.0a2&platform=linux&query_search=signature&query_type=contains&reason_type=contains&date=&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=mozalloc_abort%20%7C%20mozalloc_handle_oom%20%7C%20moz_xmalloc

Here's one crash link:

https://crash-stats.mozilla.com/report/index/f84db231-bb1b-4982-a451-193212110826

Video playback is a memory-intensive process. Should we use a fallible memory allocator there?
(Reporter)

Updated

6 years ago
Crash Signature: [@ mozalloc_abort | mozalloc_handle_oom | moz_xmalloc ]
(Assignee)

Comment 1

6 years ago
Created attachment 556309 [details] [diff] [review]
Use fallible memory allocation for BasicPlanarYCbCrImage
Attachment #556309 - Flags: review?(roc)
(Reporter)

Comment 2

6 years ago
Have you checked that memory allocated by AllocateBuffer can be freed in the same way was memory allocated by operator new[]?

Updated

6 years ago
Assignee: nobody → matt.woodrow
Severity: normal → critical
Keywords: crash, topcrash
Comment on attachment 556309 [details] [diff] [review]
Use fallible memory allocation for BasicPlanarYCbCrImage

Review of attachment 556309 [details] [diff] [review]:
-----------------------------------------------------------------

It can be freed via delete[], although that should probably be documented in ImageLayer.h.
Attachment #556309 - Flags: review?(roc) → review+

Comment 4

6 years ago
https://crash-stats.mozilla.com/report/list?range_value=4&range_unit=weeks&signature=mozalloc_abort%20|%20mozalloc_handle_oom%20|%20moz_xmalloc says this happens across multiple Firefox versions on Linux and Mac, and bug 636318 as well as bug 682595 are related or dupes.

Updated

6 years ago
Duplicate of this bug: 682595
(Assignee)

Comment 6

6 years ago
Landed on inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/62b958e49c66
http://hg.mozilla.org/mozilla-central/rev/62b958e49c66
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.