682615 - OOM crash in BasicPlanarYCbCrImage::SetData

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

This is the 6th top crasher on Firefox 8.0a2 on Linux with 4 crashes last week on 2 different machines/distros, including one on Ubuntu.

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A8.0a2&platform=linux&query_search=signature&query_type=contains&reason_type=contains&date=&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=mozalloc_abort%20%7C%20mozalloc_handle_oom%20%7C%20moz_xmalloc

Here's one crash link:

https://crash-stats.mozilla.com/report/index/f84db231-bb1b-4982-a451-193212110826

Video playback is a memory-intensive process. Should we use a fallible memory allocator there?

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Use fallible memory allocation for BasicPlanarYCbCrImage

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Have you checked that memory allocated by AllocateBuffer can be freed in the same way was memory allocated by operator new[]?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 556309 [details] [diff] [review]
Use fallible memory allocation for BasicPlanarYCbCrImage

Review of attachment 556309 [details] [diff] [review]:
-----------------------------------------------------------------

It can be freed via delete[], although that should probably be documented in ImageLayer.h.

Comment 4

[Robert Kaiser]

https://crash-stats.mozilla.com/report/list?range_value=4&range_unit=weeks&signature=mozalloc_abort%20|%20mozalloc_handle_oom%20|%20moz_xmalloc says this happens across multiple Firefox versions on Linux and Mac, and bug 636318 as well as bug 682595 are related or dupes.

Comment 6

[Matt Woodrow (:mattwoodrow)]

Landed on inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/62b958e49c66

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/62b958e49c66