Last Comment Bug 682615 - OOM crash in BasicPlanarYCbCrImage::SetData
: OOM crash in BasicPlanarYCbCrImage::SetData
: crash, topcrash
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Linux
: -- critical (vote)
: mozilla9
Assigned To: Matt Woodrow (:mattwoodrow)
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2011-08-27 14:31 PDT by Benoit Jacob [:bjacob] (mostly away)
Modified: 2011-08-31 02:16 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Use fallible memory allocation for BasicPlanarYCbCrImage (950 bytes, patch)
2011-08-27 14:42 PDT, Matt Woodrow (:mattwoodrow)
roc: review+
Details | Diff | Splinter Review

Description Benoit Jacob [:bjacob] (mostly away) 2011-08-27 14:31:35 PDT
This is the 6th top crasher on Firefox 8.0a2 on Linux with 4 crashes last week on 2 different machines/distros, including one on Ubuntu.

Here's one crash link:

Video playback is a memory-intensive process. Should we use a fallible memory allocator there?
Comment 1 Matt Woodrow (:mattwoodrow) 2011-08-27 14:42:24 PDT
Created attachment 556309 [details] [diff] [review]
Use fallible memory allocation for BasicPlanarYCbCrImage
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2011-08-27 14:49:54 PDT
Have you checked that memory allocated by AllocateBuffer can be freed in the same way was memory allocated by operator new[]?
Comment 3 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-08-28 14:20:40 PDT
Comment on attachment 556309 [details] [diff] [review]
Use fallible memory allocation for BasicPlanarYCbCrImage

Review of attachment 556309 [details] [diff] [review]:

It can be freed via delete[], although that should probably be documented in ImageLayer.h.
Comment 4 Robert Kaiser 2011-08-29 06:15:05 PDT|%20mozalloc_handle_oom%20|%20moz_xmalloc says this happens across multiple Firefox versions on Linux and Mac, and bug 636318 as well as bug 682595 are related or dupes.
Comment 5 Robert Kaiser 2011-08-29 06:31:38 PDT
*** Bug 682595 has been marked as a duplicate of this bug. ***
Comment 6 Matt Woodrow (:mattwoodrow) 2011-08-30 19:13:28 PDT
Landed on inbound:
Comment 7 Marco Bonardo [::mak] 2011-08-31 02:16:33 PDT

Note You need to log in before you can comment on or make changes to this bug.