Closed Bug 682615 Opened 8 years ago Closed 8 years ago

OOM crash in BasicPlanarYCbCrImage::SetData

Categories

(Core :: Graphics, defect, critical)

x86
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: bjacob, Assigned: mattwoodrow)

Details

(Keywords: crash, topcrash)

Crash Data

Attachments

(1 file)

Crash Signature: [@ mozalloc_abort | mozalloc_handle_oom | moz_xmalloc ]
Have you checked that memory allocated by AllocateBuffer can be freed in the same way was memory allocated by operator new[]?
Assignee: nobody → matt.woodrow
Severity: normal → critical
Keywords: crash, topcrash
Comment on attachment 556309 [details] [diff] [review]
Use fallible memory allocation for BasicPlanarYCbCrImage

Review of attachment 556309 [details] [diff] [review]:
-----------------------------------------------------------------

It can be freed via delete[], although that should probably be documented in ImageLayer.h.
Attachment #556309 - Flags: review?(roc) → review+
https://crash-stats.mozilla.com/report/list?range_value=4&range_unit=weeks&signature=mozalloc_abort%20|%20mozalloc_handle_oom%20|%20moz_xmalloc says this happens across multiple Firefox versions on Linux and Mac, and bug 636318 as well as bug 682595 are related or dupes.
Duplicate of this bug: 682595
http://hg.mozilla.org/mozilla-central/rev/62b958e49c66
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.