682651 - "ASSERTION: Element without owner document" with createDocumentType

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Element without owner document: 'Error', file content/base/src/nsGenericElement.cpp, line 1372

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

The NS_ERROR is just wrong, but to get right behavior after bug 675166 is fixed,
we should use GetOwnerDocument.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 556386 [details] [diff] [review]
patch

Review of attachment 556386 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsGenericElement.cpp
@@ +1364,5 @@
>  
>  already_AddRefed<nsIURI>
>  nsIContent::GetBaseURI() const
>  {
> +  nsIDocument* doc = GetOwnerDocument();

Why this change? This is slightly slower. Not that it matters perf wise, but doesn't seem like a win either.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Because after bug 675166 GetOwnerDoc() will actually return something in this case, 
and we don't actually want that something but null.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

But ok, if DOM Core has changed, this patch is wrong.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 556386 [details] [diff] [review]
patch

So, the spec has changed and this will be fixed in the bug which makes
GetOwnerDoc to return always a valid value.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Fixed in bug 675166