682683 - Addon test failure - TypeError: descriptor 'lower' requires a 'str' object but received a 'unicode'

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg: Flashblock - http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/addontester-linux/1313106963/addontester_fedora_test-addon-build24.txt.gz

Running test ts: 
		Started Sun, 28 Aug 2011 01:29:08
Traceback (most recent call last):
  File "run_tests.py", line 540, in <module>
    test_file(arg, screen, amo)
  File "run_tests.py", line 485, in test_file
    browser_dump, counter_dump, print_format = mytest.runTest(browser_config, test)
  File "/home/cltbld/talos-slave/talos-data/talos/ttest.py", line 234, in runTest
    profile_dir, temp_dir = self.createProfile(test_config['profile_path'], browser_config)
  File "/home/cltbld/talos-slave/talos-data/talos/ttest.py", line 134, in createProfile
    browser_config['extensions'])
  File "/home/cltbld/talos-slave/talos-data/talos/ffsetup.py", line 247, in CreateTempProfileDir
    self.install_addon(profile_dir, addon)
  File "/home/cltbld/talos-slave/talos-data/talos/ffsetup.py", line 196, in install_addon
    if (str.lower(unpack) == 'true'):  #install addon unpacked
TypeError: descriptor 'lower' requires a 'str' object but received a 'unicode'

Depends on bug 680962 only in the sense that we discovered it there, and RelEng has to fix that to get regular addon perf tests.

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: [checked in]convert unicode to string

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 556554 [details] [diff] [review]
[checked in]convert unicode to string

Review of attachment 556554 [details] [diff] [review]:
-----------------------------------------------------------------

can you fix this in mozmill also:
https://github.com/mozautomation/mozmill/blob/master/mozprofile/mozprofile/addons.py#L160

Comment 3

[alice nodelman [:alice] [:anode]]

Comment on attachment 556554 [details] [diff] [review]
[checked in]convert unicode to string

changeset:   250:ba94d2a40f17

Comment 4

[Jeff Hammel]

Trying to reproduce for mozmill.

Comment 5

[Jeff Hammel]

So

 mozprofile -a https://addons.mozilla.org/firefox/downloads/latest/433/addon-433-latest.xpi

works as expected.  Does this mean there isn't an issue?  Or does anyone have a repro case?

Comment 6

[Jeff Hammel]

So Mozprofile doesn't unpack things selectively ATM : bug 662683 . This can/will become an issue if this happens.

Comment 7

[alice nodelman [:alice] [:anode]]

Change deployed.