Sprinkle some do_QueryObject fairy dust around the tree

RESOLVED FIXED in mozilla9

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: marco)

Tracking

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

Back in the days before do_QueryObject, you had to write:

nsCOMPtr<nsIFoo> = do_QueryInterface(static_cast<nsIBar>(someVariableOfAConcreteType));

These days, you can just write:

nsCOMPtr<nsIFoo> = do_QueryObject(someVariableOfAConcreteType);

The MXR query shows some usages that haven't been converted, and I'm pretty sure all of them can be converted.
(Assignee)

Updated

6 years ago
Assignee: nobody → mar.castelluccio
(Assignee)

Comment 1

6 years ago
Created attachment 556621 [details] [diff] [review]
First patch
Attachment #556621 - Flags: review?(khuey)
would be nice if you collapsed the lines that are now under 80 characters long ...
(Assignee)

Comment 3

6 years ago
Created attachment 556738 [details] [diff] [review]
First patch v2

Collapsed the lines ;)
Attachment #556621 - Attachment is obsolete: true
Attachment #556621 - Flags: review?(khuey)
Attachment #556738 - Flags: review?(khuey)
Attachment #556738 - Flags: review?(khuey) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 4

6 years ago
In my queue :-)
Status: NEW → ASSIGNED
Keywords: checkin-needed
Version: 8 Branch → Trunk

Updated

6 years ago
Flags: in-testsuite-

Comment 5

6 years ago
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=e9351f9ab296

http://hg.mozilla.org/integration/mozilla-inbound/rev/31b7b26ff4f9

Updated

6 years ago
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/31b7b26ff4f9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.