682744 - Sprinkle some do_QueryObject fairy dust around the tree

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Back in the days before do_QueryObject, you had to write:

nsCOMPtr<nsIFoo> = do_QueryInterface(static_cast<nsIBar>(someVariableOfAConcreteType));

These days, you can just write:

nsCOMPtr<nsIFoo> = do_QueryObject(someVariableOfAConcreteType);

The MXR query shows some usages that haven't been converted, and I'm pretty sure all of them can be converted.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: First patch

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

would be nice if you collapsed the lines that are now under 80 characters long ...

Comment 3

[Marco Castelluccio [:marco]]

Attachment: First patch v2

Collapsed the lines ;)

Comment 4

[Ed Morley [:emorley]]

In my queue :-)

Comment 5

[Ed Morley [:emorley]]

http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=e9351f9ab296

http://hg.mozilla.org/integration/mozilla-inbound/rev/31b7b26ff4f9

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/31b7b26ff4f9