Closed Bug 682759 Opened 8 years ago Closed 8 years ago

NPRemoteWindow.window shouldn't be unsigned long

Categories

(Core :: Plug-ins, defect)

x86_64
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox9 --- fixed

People

(Reporter: m_kato, Assigned: jaas)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

NPWindow.window is HWND in Windows.  It is that Win32 is 4 bytes, Win64 is 8bytes.

But NPRemoteWindow.window is defined as unsigned long... Since Win64 model is LLP64, sizeof(unsigned long) is 4, not 8.
Correct me if I'm wrong but "unsigned long" is generally 64 bits on 64-bit Unix machines and 32 bits on 64-bit Windows machines. This means casting void* to unsigned long and back would probably work on Unix but not on Windows, which would explain why nobody reported this for Linux but it is an issue on Windows...
Assignee: m_kato → joshmoz
Attached patch fix v1.0Splinter Review
This is ugly, but maybe less ugly?
Attachment #556858 - Flags: review?(m_kato)
Attachment #556858 - Flags: review?(m_kato) → review+
Attachment #556858 - Flags: review?(jones.chris.g)
Attachment #556858 - Flags: review?(jones.chris.g) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/1bba630bb3a0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Nothing here that QA needs to verify.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.