Closed
Bug 682759
Opened 13 years ago
Closed 13 years ago
NPRemoteWindow.window shouldn't be unsigned long
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox9 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox9 | --- | fixed |
People
(Reporter: m_kato, Assigned: jaas)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
5.69 KB,
patch
|
m_kato
:
review+
cjones
:
review+
|
Details | Diff | Splinter Review |
NPWindow.window is HWND in Windows. It is that Win32 is 4 bytes, Win64 is 8bytes. But NPRemoteWindow.window is defined as unsigned long... Since Win64 model is LLP64, sizeof(unsigned long) is 4, not 8.
Correct me if I'm wrong but "unsigned long" is generally 64 bits on 64-bit Unix machines and 32 bits on 64-bit Windows machines. This means casting void* to unsigned long and back would probably work on Unix but not on Windows, which would explain why nobody reported this for Linux but it is an issue on Windows...
Attachment #556858 -
Flags: review?(m_kato)
|
Reporter | |
Updated•13 years ago
|
Attachment #556858 -
Flags: review?(m_kato) → review+
Attachment #556858 -
Flags: review?(jones.chris.g)
|
||
Updated•13 years ago
|
Attachment #556858 -
Flags: review?(jones.chris.g) → review+
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/1bba630bb3a0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
status-firefox9:
--- → fixed
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•