Closed Bug 682794 Opened 8 years ago Closed 8 years ago

autoconf.mk is not rebuilt when autoconf.mk.in changes

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file)

When I landed bug 676252, I got failures on OSX and Windows builds because they were getting an empty string for OBJ_SUFFIX. The only reason I can think of to explain that is if autoconf.mk was not refreshed.

In fact, the backout of bug 676252 failed on platforms where the bug 676252 landing worked because of that: autoconf.mk was still containing the $(error) value, while config/config.mk was not resetting it anymore, leading to an error.
There is a rule in client.mk to refresh autoconf.mk, but nothing depends on it. Also, nothing takes care of js/src/config/autoconf.mk.
I think autoconf.mk should be refreshed, like Makefiles, from rules.mk.
Comment on attachment 556486 [details] [diff] [review]
Refresh autoconf.mk when autoconf.mk.in is modified

This scares me a little bit, but ok. r=me
Attachment #556486 - Flags: review?(khuey) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.