Note: There are a few cases of duplicates in user autocompletion which are being worked on.

autoconf.mk is not rebuilt when autoconf.mk.in changes

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
When I landed bug 676252, I got failures on OSX and Windows builds because they were getting an empty string for OBJ_SUFFIX. The only reason I can think of to explain that is if autoconf.mk was not refreshed.

In fact, the backout of bug 676252 failed on platforms where the bug 676252 landing worked because of that: autoconf.mk was still containing the $(error) value, while config/config.mk was not resetting it anymore, leading to an error.
(Assignee)

Comment 1

6 years ago
There is a rule in client.mk to refresh autoconf.mk, but nothing depends on it. Also, nothing takes care of js/src/config/autoconf.mk.
I think autoconf.mk should be refreshed, like Makefiles, from rules.mk.
(Assignee)

Comment 2

6 years ago
Created attachment 556486 [details] [diff] [review]
Refresh autoconf.mk when autoconf.mk.in is modified
Attachment #556486 - Flags: review?(khuey)
Comment on attachment 556486 [details] [diff] [review]
Refresh autoconf.mk when autoconf.mk.in is modified

This scares me a little bit, but ok. r=me
Attachment #556486 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/projects/build-system/rev/3aa52a5e7e5c
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/3aa52a5e7e5c
Assignee: nobody → mh+mozilla
Target Milestone: --- → mozilla9
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.