682794 - autoconf.mk is not rebuilt when autoconf.mk.in changes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

When I landed bug 676252, I got failures on OSX and Windows builds because they were getting an empty string for OBJ_SUFFIX. The only reason I can think of to explain that is if autoconf.mk was not refreshed.

In fact, the backout of bug 676252 failed on platforms where the bug 676252 landing worked because of that: autoconf.mk was still containing the $(error) value, while config/config.mk was not resetting it anymore, leading to an error.

Comment 1

[Mike Hommey [:glandium]]

There is a rule in client.mk to refresh autoconf.mk, but nothing depends on it. Also, nothing takes care of js/src/config/autoconf.mk.
I think autoconf.mk should be refreshed, like Makefiles, from rules.mk.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Refresh autoconf.mk when autoconf.mk.in is modified

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 556486 [details] [diff] [review]
Refresh autoconf.mk when autoconf.mk.in is modified

This scares me a little bit, but ok. r=me

Comment 4

[Mike Hommey [:glandium]]

http://hg.mozilla.org/projects/build-system/rev/3aa52a5e7e5c

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/3aa52a5e7e5c