Closed
Bug 682871
Opened 11 years ago
Closed 11 years ago
make package fails when $(MOZILLA_DIR) is a relative path
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
1.05 KB,
patch
|
Callek
:
review+
ted
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Ted suggested this fix and it WFM.
Comment 2•11 years ago
|
||
Comment on attachment 556594 [details] [diff] [review] fix That looks right, given the number of places we call GENERATE_CACHE and what this is doing.
Attachment #556594 -
Flags: review+
Assignee | ||
Comment 3•11 years ago
|
||
Oh, but you know what? We should find out if xpcshell is actually exiting with a nonzero exit code in this case, and if so, fix the makefile to notice the error. (It is a kind of complicated command with some () and some && and some ; up in there.) If it's xpcshell's fault, we should fix that, separate bug I guess.
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Jason Orendorff [:jorendorff] from comment #3) > Oh, but you know what? We should find out if xpcshell is actually exiting > with a nonzero exit code in this case, and if so, fix the makefile to notice > the error. (It is a kind of complicated command with some () and some && and > some ; up in there.) By "we", of course, I mean "y'all". I checked and it looks like xpcshell's exit code is 3 in this case, so I guess a Makefile fix would be the thing.
Assignee | ||
Updated•11 years ago
|
Attachment #556594 -
Flags: superreview?(ted.mielczarek)
Updated•11 years ago
|
Attachment #556594 -
Flags: superreview?(ted.mielczarek) → superreview+
Assignee | ||
Comment 5•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/7509ecc14e9e
Whiteboard: [inbound]
Comment 6•11 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7509ecc14e9e
Assignee: nobody → jorendorff
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•