682888 - Topcrasher list doesn't validate to its doctype

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Tobias (:Tobbi) Markus]

See http://validator.w3.org/check?uri=https%3A%2F%2Fcrash-stats.allizom.org%2Ftopcrasher%2Fbyversion%2FCamino%2F2.1b1%2F14&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.2 for the full report

First of all we should escape & in crash report IDs properly as & right?

Then somewhere there's a closing tag missing. (many followup issues)

Comment 1

[Schalk Neethling [:espressive]]

hmmm, currently https://crash-stats.mozilla.com/topcrasher/byversion/Firefox/10.0a1 the validator reports Sorry! This document can not be checked.

Comment 2

[Robert Helmer [:rhelmer]]

Still some issues: http://html5.validator.nu/?doc=https%3A%2F%2Fcrash-stats.mozilla.com%2Ftopcrasher%2Fproducts%2FFirefox%2Fversions%2F26.0a1%3Fdays%3D7

Comment 3

[Schalk Neethling [:espressive]]

(In reply to Robert Helmer [:rhelmer] from comment #2)
> Still some issues:
> http://html5.validator.nu/?doc=https%3A%2F%2Fcrash-stats.mozilla.
> com%2Ftopcrasher%2Fproducts%2FFirefox%2Fversions%2F26.0a1%3Fdays%3D7

I currently working on validating all the pages of the site, basically just report/index that still is untested because I am battling to get that page to load locally.

Comment 4

[Schalk Neethling [:espressive]]

This has been rolled up into https://bugzilla.mozilla.org/show_bug.cgi?id=788063

Comment 5

[Schalk Neethling [:espressive]]

Sent pull request: https://github.com/mozilla/socorro/pull/1433

Comment 6

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

Verified on stage - http://html5.validator.nu/?doc=https%3A%2F%2Fcrash-stats.allizom.org%2Ftopcrasher%2Fproducts%2FFirefox%2Fversions%2F26.0a1%3Fdays%3D7