Created attachment 556624 [details]
"-moz-transform-style: fixed" is parsed as "preserve-3d". I'm guessing this isn't intentional, based on looking at patch 14a in bug 505115.
Created attachment 557034 [details] [diff] [review]
Test for invalid value to -moz-transform-style
I can see the same behaviour here, but I'm not sure why.
I tried adding the above tests to catch this behaviour, and they pass.
Maybe you need "eCSSKeyword_UNKNOWN,-1" at the end of kTransformStyleKTable. (The table above it also seems to be missing that. Not the sanest API.)
Yes, that's needed. Not sure what alternative API you'd suggest; you either need a terminator or a length.
You could compute the length using NS_ARRAY_LENGTH instead of specifying it.
I suppose so, but then we'd need to pass that length around in a whole bunch of places, or add a structure wrapping the length and a pointer to the list (probably the better option).
Created attachment 563929 [details] [diff] [review]
Thanks Jesse, good catch.
Comment on attachment 563929 [details] [diff] [review]