682919 - "-moz-transform-style: fixed" is parsed as preserve-3d

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

"-moz-transform-style: fixed" is parsed as "preserve-3d". I'm guessing this isn't intentional, based on looking at patch 14a in bug 505115.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Test for invalid value to -moz-transform-style

I can see the same behaviour here, but I'm not sure why.

I tried adding the above tests to catch this behaviour, and they pass.

Comment 2

[Jesse Ruderman]

Maybe you need "eCSSKeyword_UNKNOWN,-1" at the end of kTransformStyleKTable. (The table above it also seems to be missing that. Not the sanest API.)

http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSProps.cpp#590

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes, that's needed.  Not sure what alternative API you'd suggest; you either need a terminator or a length.

Comment 4

[Jesse Ruderman]

You could compute the length using NS_ARRAY_LENGTH instead of specifying it.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I suppose so, but then we'd need to pass that length around in a whole bunch of places, or add a structure wrapping the length and a pointer to the list (probably the better option).

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Add eCSSKeyword_UNKNOWN

Thanks Jesse, good catch.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 563929 [details] [diff] [review]
Add eCSSKeyword_UNKNOWN

r=dbaron

Comment 8

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91055546d0cb

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/91055546d0cb