68296 - Cyrus IMAP: Can't unsubscribe from 2,3, ... level IMAP folder

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Alexei V. Mokeev]

Steps to reproduce:
1.Create IMAP subfolder(For example subfoilder of INBOX)
2.Subcribe to it
3.Unsubscribe from it
4.Open "Subscribe" window and note, that you is still subscribed
on this folder.

Reproduced under Intel Solaris 2.7
Reprodusible: Always
Build: Mozilla/5.0 (X11; U; SunOS 5.7 i86pc; en-US; m18) Gecko/20010123 
Netscape6/6.0 
IMAP server: Cyrus IMAP4 v2.0.9

Comment 1

[Alexei V. Mokeev]

Add CC

Comment 2

[(not reading, please use [e-mail] instead)]

what type of imap server?

Comment 3

[(not reading, please use [e-mail] instead)]

IMAP server: Cyrus IMAP4 v2.0.9

I should read more carefully.

Comment 4

[(not reading, please use [e-mail] instead)]

is this on the Netscape OEM branch?

if so, try a trunk build.  a lot of subscribe improvements have happened since
that branch.

Comment 5

[Shirley Liu]

It works on Mozilla build 2001040604 for PC win2000.

Comment 6

[Shirley Liu]

Tested Netscape6.01A on Sparc Solaris 2.8 and Mozilla build 2001040904 on PC
win2000.  I tried to create IMAP subfolder failed. First of all, I could not
create any subfolder under INBOX, the INBOX has been greyed out. The second
test was creating any subfolder under IMAP (except INBOX) failed with error
message "The current command did not succeed. The mail server responded:
CREATE failed: Can't create mailbox node /home/sl116442/Trash: File exists".
But, I tried to have subfolder name for Trash is "Trash1" which was a different
name. The IMAP server is single.eng.sun.com.

Comment 7

[Alexei V. Mokeev]

Not all IMAP servers allow creation of subfolders.
You may use Cyrus IMAP server for test this operation.
This bug is still reproduced for me with Cysrus IMAP v2.0.9
and Mozilla's build 2001040805 under Linux. 

Comment 8

[Raghu Sakleshpur]

Marking the bug OS category to Linux for now based on Alexei's comments.

Comment 9

[scottputterman]

adding nsenterprise-

Comment 10

[scottputterman]

wrong bug.  adding nsenterprise+

Comment 11

[Karen Huang]

Yes. I can reproduce this problem on the 08-02-06-trunk build.

Comment 12

[Cavin Song]

Taking from sspitzer.

Comment 13

[Cavin Song]

Attachment: Fixed the problem.

Comment 14

[Cavin Song]

Basically, in nsImapProtocol::Subscribe() and nsImapProtocol::Unsubscribe() we
need to restore the folder pathname back to original one (ie, the one sent by 
the server for the list/lsub response). For example, 'INBOX/subfld' should be 
changed/converted to 'INBOX.subfld' before sending it to the Cyrus server, 
otherwise the cmd will fail.

bienvenu and sspitzer can you r and sr it? Thanks.

Comment 15

[Cavin Song]

Forgot to cc bienvenu.

Comment 16

[David :Bienvenu]

Not sure about this - I'm thinking maybe the caller should not be passing in
folder names with the hierarchical delimiter, but let me think about it a little
bit.

Comment 17

[Cavin Song]

Attachment: A better fix.

Comment 18

[David :Bienvenu]

looks good, Cavin, thanks for working on this - r=bienvenu

Comment 19

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 20

[Cavin Song]

Fix checked in.

Comment 21

[Bradley Baetz (:bbaetz)]

This was checked in with ^Ms in it, which broke some of the ports. timeless
fixed it for you. Check that cygwin is configured correctly.

Comment 22

[Cavin Song]

Sorry about that. This is not the first time that I've checked in stuff and I've
not changed any settings on my development machine so I'm not sure what happened
to it this time.  However, I'll investigate the cause.

Comment 23

[Karen Huang]

Verified on 08-23-08-trunk build.
This is working now on the Cyrus server for unsubscribe functionality.
Can I mark as verified for this bug? But I am wondering to know what the impact 
from the previous comments?

Comment 24

[Cavin Song]

Yes Karen, you can mark it as VERIFIED. There was some problem with the code I
checked in but it was fixed by Bradley so it's not a problem anymore.

Comment 25

[Karen Huang]

Thanks. 
Good work, Cavin. Marking as verified then.