Last Comment Bug 682970 - nsObjectLoadingContent::StartPluginInstance: continue with instantiation if mInstanceOwner already exists?
: nsObjectLoadingContent::StartPluginInstance: continue with instantiation if m...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: John Schoenick [:johns]
:
: Benjamin Smedberg [:bsmedberg]
Mentors:
Depends on: 745030
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-29 14:13 PDT by Josh Aas
Modified: 2012-08-07 18:01 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Josh Aas 2011-08-29 14:13:44 PDT
From biesi's review of my patch on bug 90268:

> +nsObjectLoadingContent::StartPluginInstance()
> +{
> +  // OK to have an instance already.
> +  if (mInstanceOwner) {
> +    return NS_OK;

Hm... is this correct? Don't you have to still call Instantiate in this case? Consider an <object data="foo.swf"> getting a .setAttribute("data", "bar.mov") call.
Comment 1 John Schoenick [:johns] 2012-08-07 18:01:57 PDT
Bug 745030 makes state-changed logic in LoadObject(), which is triggered on appropriate attribute changes, so this should be fine. The few cases where we try to call StartPluginInstance() from outside code are generally trying to speed up an async instantiation, and cleaning that up is part of bug 767635

Note You need to log in before you can comment on or make changes to this bug.