nsObjectLoadingContent::StartPluginInstance: continue with instantiation if mInstanceOwner already exists?

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: johns)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
From biesi's review of my patch on bug 90268:

> +nsObjectLoadingContent::StartPluginInstance()
> +{
> +  // OK to have an instance already.
> +  if (mInstanceOwner) {
> +    return NS_OK;

Hm... is this correct? Don't you have to still call Instantiate in this case? Consider an <object data="foo.swf"> getting a .setAttribute("data", "bar.mov") call.
(Assignee)

Updated

5 years ago
Depends on: 745030
(Assignee)

Updated

5 years ago
Assignee: nobody → jschoenick
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 1

5 years ago
Bug 745030 makes state-changed logic in LoadObject(), which is triggered on appropriate attribute changes, so this should be fine. The few cases where we try to call StartPluginInstance() from outside code are generally trying to speed up an async instantiation, and cleaning that up is part of bug 767635
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.