Closed Bug 682970 Opened 10 years ago Closed 10 years ago

nsObjectLoadingContent::StartPluginInstance: continue with instantiation if mInstanceOwner already exists?

Categories

(Core :: Plug-ins, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: johns)

References

Details

From biesi's review of my patch on bug 90268:

> +nsObjectLoadingContent::StartPluginInstance()
> +{
> +  // OK to have an instance already.
> +  if (mInstanceOwner) {
> +    return NS_OK;

Hm... is this correct? Don't you have to still call Instantiate in this case? Consider an <object data="foo.swf"> getting a .setAttribute("data", "bar.mov") call.
Depends on: 745030
Assignee: nobody → jschoenick
OS: Mac OS X → All
Hardware: x86 → All
Bug 745030 makes state-changed logic in LoadObject(), which is triggered on appropriate attribute changes, so this should be fine. The few cases where we try to call StartPluginInstance() from outside code are generally trying to speed up an async instantiation, and cleaning that up is part of bug 767635
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.