68303 - Can't unsubscribe from newsgroup if its name has a non-ASCII character in it

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Alexei V. Mokeev]

Steps to reproduce:
1. Type in the browser locator field news url and end it with "\"
 (e.g news://news.mozilla.org/netscape.public.mozilla.xpcom\)
 -Messenger window will be opened.
2. Try to unsubscribe from this group - you can do it only via "del" key
3. Restart and note that this news group is still present in list

Reproduced under Intel Solaris 2.7.
Build:Mozilla/5.0 (X11; U; SunOS 5.7 i86pc; en-US; m18) Gecko/20010123 
Netscape6/6.0
Tag info as follows: [tag: -r Netscape_6_0_OEM_BRANCH -D "01/19/2001 10:00:00"  
         PSM: 1.4 (PSM_1_4_N6) & NSS 3.1 (NSS_3_1_RTM tag)

Comment 1

[(not reading, please use [e-mail] instead)]

which type of IMAP server?

Netscape_6_0_OEM_BRANCH?  try a trunk build, a lot of subscribe changes have
happened on the trunk.

Comment 2

[(not reading, please use [e-mail] instead)]

zoinks, this isn't even imap.  I need to wake up.

accepting

Comment 3

[Håkan Waara]

You can trigger this if your newsgroup's name has *any* non-ascii character.

Comment 4

[Håkan Waara]

Attachment: Patch -uw

The problem was that we were passing an unescaped string to
nsMsgFolder::FindSubFolder() which then was failing and gave us a bogus folder
that made it so the function that actually deletes our folder failed
(nsMsgFolder::PropagateDelete).

The fix is to escape the newsgroup name, and to add a comment above
FindSubFolder() so no one else will make the same mistake in the future.

Comment 5

[Håkan Waara]

Reassign to self.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

hwaara's fix was correct.  

this just fixes the comment and some style / white space issues.

Comment 7

[(not reading, please use [e-mail] instead)]

the comment to FindSubFolder() is not correct.

how news chooses to handle names (escaping them to handle non-ASCII) is not 
true for all callers of FindSubFolder.

Comment 8

[(not reading, please use [e-mail] instead)]

to test, exit, add håkan to your newsrc file for news.mozilla.org and start up 
and expand news.mozilla.org

Comment 9

[(not reading, please use [e-mail] instead)]

fix checked in for hwaara.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Mac and win32 are fine, just waiting on bug 110158 before I mark this verified.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED:

Windows 2K - 2001-11-16-03
Mac OS 10.1 - 2001-11-16-09
RedHat 7.2 - 2001-16-06