Closed Bug 683069 Opened 15 years ago Closed 14 years ago

rm setParent hack in JSCompartment::wrap

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(1 file)

There is a hack in JSCompartment::wrap where we reparent wrappers to the current global whenever an existing wrapper is found in the crossCompartmentWrappers map. This apparently prevents hideous browser leaks. Fortunately, compartment-per-global should makes this code unnecessary since obj->getGlobal() will necessarily equal 'global'.
Attached patch patch — — Splinter Review
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #641708 - Flags: review?(bobbyholley+bmo)
Comment on attachment 641708 [details] [diff] [review] patch r=me if it's green.
Attachment #641708 - Flags: review?(bobbyholley+bmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: