rm setParent hack in JSCompartment::wrap

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
There is a hack in JSCompartment::wrap where we reparent wrappers to the current global whenever an existing wrapper is found in the crossCompartmentWrappers map.  This apparently prevents hideous browser leaks.  Fortunately, compartment-per-global should makes this code unnecessary since obj->getGlobal() will necessarily equal 'global'.
(Assignee)

Comment 1

5 years ago
Created attachment 641708 [details] [diff] [review]
patch

So far, so green:
https://tbpl.mozilla.org/?tree=Try&rev=b3e9b404dd35
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #641708 - Flags: review?(bobbyholley+bmo)
Comment on attachment 641708 [details] [diff] [review]
patch

r=me if it's green.
Attachment #641708 - Flags: review?(bobbyholley+bmo) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/02bffdc6ce7f
Target Milestone: --- → mozilla17

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/02bffdc6ce7f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.