Closed
Bug 683069
Opened 15 years ago
Closed 14 years ago
rm setParent hack in JSCompartment::wrap
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(1 file)
|
718 bytes,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
There is a hack in JSCompartment::wrap where we reparent wrappers to the current global whenever an existing wrapper is found in the crossCompartmentWrappers map. This apparently prevents hideous browser leaks. Fortunately, compartment-per-global should makes this code unnecessary since obj->getGlobal() will necessarily equal 'global'.
| Assignee | ||
Comment 1•14 years ago
|
||
So far, so green:
https://tbpl.mozilla.org/?tree=Try&rev=b3e9b404dd35
Comment 2•14 years ago
|
||
Comment on attachment 641708 [details] [diff] [review]
patch
r=me if it's green.
Attachment #641708 -
Flags: review?(bobbyholley+bmo) → review+
| Assignee | ||
Comment 3•14 years ago
|
||
Target Milestone: --- → mozilla17
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•