683085 - NativeParentWidget used incorrectly in Widget Qt port

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

Currently we are casting aNativeParent widget to MozQWidget and trying to get Receiver in createQWidget function, which is going to be incorrect in case of embedding (when nativeParent will be just QGraphicsWidget from 3rd party embedding application)

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Fix embedding widget initialization in Qt port

Also created Magic parent widget handle, in order to make it possible to init mozqwidget without any parent (windowless embedding).

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 556753 [details] [diff] [review]
Fix embedding widget initialization in Qt port

Review of attachment 556753 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/qt/nsWindow.cpp
@@ +136,5 @@
>  #define GLdouble_defined 1
>  #include "Layers.h"
>  #include "LayerManagerOGL.h"
>  
> +#define PARENTLESS_WIDGET (void*)0x13579

What the hell is this? ;D

Comment 3

[Oleg Romashin (:romaxa)]

it is the hack, in order to allow to create nsIWidget without native and non-native parent,
Current code like this: http://mxr.mozilla.org/mozilla-central/source/embedding/browser/webBrowser/nsWebBrowser.cpp#1120
does not allow us to create BaseWindow without any parent, but that would be useful for windowless embedding or creating simple rendering base and get rendered layout from Layout::RenderDocument API...

This hack simply allow to pass that narrow place and detect this mode.

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 556753 [details] [diff] [review]
Fix embedding widget initialization in Qt port

Review of attachment 556753 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you add a comment about that value.

::: widget/src/qt/nsWindow.cpp
@@ +136,5 @@
>  #define GLdouble_defined 1
>  #include "Layers.h"
>  #include "LayerManagerOGL.h"
>  
> +#define PARENTLESS_WIDGET (void*)0x13579

You need to comment why this value is picked.

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Added comment, to push

Moving r+

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22ae18b4d013

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/22ae18b4d013