68317 - mozilla-2001-02-08-08-Mtrunk build with --with-xprint breaks with Sun Workshop 6U2EA...

Status: VERIFIED DUPLICATE of bug 68779

(Core Graveyard :: Printing: Xprint, defect)

Description

[Roland Mainz]

Mozilla build from mozilla-2001-02-08-08-Mtrunk with --with-xprint using Sun
Workshop 6 Update 2 EarlyAccess fails like this:
-- snip --
/opt/SUNWspro/bin/CC -library=iostream -o nsXPrintContext.o -c
-DOSTYPE=\"SunOS5\" -DOJI -D_IMPL_NS_GFXONXP -DUSE_MOZILLA_TYPES  
-I../../../dist/include -I../../../dist/include     
-I../../../../gfx/src/xprint/../gtk -I../../../../gfx/src/xprint/../xlibrgb 
-I/usr/openwin/include   -KPIC  -mt -xO1  -DDEBUG -DDEBUG_gisburn -DTRACING -g
-I/usr/local/lib/glib/include -I/usr/local/include -I/usr/openwin/include
-DMOZILLA_CLIENT -DBROKEN_QSORT=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1
-DD_INO=d_ino -DMOZ_WIDGET_GTK=1 -DMOZ_ENABLE_XREMOTE=1
-DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1
-DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1
-DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1
-DHAVE_UNISTD_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_STATVFS_H=1
-DHAVE_SYS_STATFS_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1
-DHAVE_LIBDL=1 -DHAVE_LIBSOCKET=1 -DHAVE_LIBPOSIX4=1 -D_REENTRANT=1
-DHAVE_RANDOM=1 -DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_USLEEP=1 -DHAVE_RINT=1 -DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1
-DHAVE_DEV_ZERO=1 -DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_SPECIALIZATION=1 -DHAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX=1
-DHAVE_CPP_PARTIAL_SPECIALIZATION=1 -DHAVE_CPP_ACCESS_CHANGING_USING=1
-DHAVE_CPP_AMBIGUITY_RESOLVING_USING=1 -DHAVE_CPP_NAMESPACE_STD=1
-DHAVE_CPP_UNAMBIGUOUS_STD_NOTEQUAL=1 -DHAVE_CPP_NEW_CASTS=1
-DHAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR=1 -DNEED_CPP_UNUSED_IMPLEMENTATIONS=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_MAIL_NEWS=1 -DMOZ_ENDER_LITE=1
-DNS_MT_SUPPORTED=1 -DCPP_CV_QUALIFIERS_CAUSE_AMBIGUITY=1
-DDETECT_WEBSHELL_LEAKS=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_MATHML=1 -DMOZ_SVG=1
-DMOZ_XSL=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1
-DHAVE_MOVEMAIL=1 -DJS_THREADSAFE=1 
../../../../gfx/src/xprint/nsXPrintContext.cpp
"/usr/include/strings.h", line 28: Error: Only one of a set of overloaded
functions can be extern "C".
"/usr/include/strings.h", line 28: Error: std::strchr(const char*, int),
returning char*, was previously declared returning const char*.
"/usr/include/strings.h", line 29: Error: Only one of a set of overloaded
functions can be extern "C".
"/usr/include/strings.h", line 29: Error: std::strrchr(const char*, int),
returning char*, was previously declared returning const char*.
"../../../../gfx/src/xprint/nsXPrintContext.cpp", line 108: Warning
(Anachronism): Formal argument 1 of type extern "C"
int(*)(_XDisplay*,XErrorEvent*) in call to XSetErrorHandler(extern "C"
int(*)(_XDisplay*,XErrorEvent*)) is being passed
int(*)(_XDisplay*,XErrorEvent*).
4 Error(s) and 1 Warning(s) detected.
make: *** [nsXPrintContext.o] Error 4
-- snip --

Comment 1

[Roland Mainz]

Mhhh, fix looks simple:
Add #include <strings.h> to nsXPrintContext.cpp...

Patch looks like this:
-- snip --
mozilla-2001-02-08-08-Mtrunk/mozilla/gfx/src/xprint% diff -c -w
nsXPrintContext.cpp.original nsXPrint
Context.cpp
*** nsXPrintContext.cpp.original        Fri Feb  9 18:43:21 2001
--- nsXPrintContext.cpp Fri Feb  9 18:44:26 2001
***************
*** 22,27 ****
--- 22,29 ----
  
  #include <stdio.h>
  #include <stdlib.h>
+ #include <strings.h>
+ 
  #include "xlibrgb.h"
  #include "nsXPrintContext.h"
-- snip --

Seems to be fixed... :-)

Is it possible to get this in for Mozilla .8, please ?

Comment 2

[Christopher Blizzard (:blizzard)]

a,sr=blizzard.  Get it in quick.

Comment 3

[Asa Dotzler [:asa]]

last call for 0.8 fix. Roland Mainz, Masaki Katakai, ths needs to go in in
immediately if it's gonna make the 0.8 train.

Comment 4

[Roland Mainz]

What do you need ? Patched tree builds&works with both WS6U2RA and gcc... Isn't
the diff there in the BugZilla page enougth ?

Comment 5

[Andreas Franke (gone)]

Maybe blizzard & asa were assuming that you (Roland) have CVS access? These days
you have to send private mails or ask on IRC for help and assistance. The 0.8
train may be gone, but maybe this helps next time. You can't rely on all bug
owners reacting to bugzilla comments in time.

Comment 6

[Roland Mainz]

> You can't rely on all bug owners reacting to bugzilla comments in time

I know... ;-((

Hopefully noone kills me if I release a .8 build where this issue has been fixed
"by hand"... =:-)

Comment 7

[Masaki Katakai]

Moved to 0.9 for target.

Roland, do you have CVS access? If so, I'd like to reassgin this bug to you.
If not, I'll check-in the patch.

Comment 8

[Roland Mainz]

> Roland, do you have CVS access? 

Sorry... not yet... ;-(

> If so, I'd like to reassgin this bug to you.
> If not, I'll check-in the patch.

Yes... please... :-)

Comment 9

[Roland Mainz]

BTW: This bug may be somehow "obsolete"... see my comments in bug 68779 ("Roland
Mainz 2001-02-22 15:03").... I'd like to hack the most-up-to-date version to be
more useable and DAU[1]-tolerant (--> XprintUtils)...

[1]=german abbreviation for "not-so-well-trained user"... =:-)

Comment 10

[Masaki Katakai]

Attachment: simple patch

Comment 11

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 12

[Roland Mainz]

I assume we can mark this as "fixed" if possible... I'd like to rubber-stamp it
"verified"... :-)

Comment 13

[Masaki Katakai]

Roland, OK, please mark this as dup of bug 68779.

Comment 14

[Roland Mainz]

Marking as duplicate of bug 68779
katakai...do you verify ?

*** This bug has been marked as a duplicate of 68779 ***

Comment 15

[Chad Austin]

verified dups