683188 - nsISound should be used in Win32 widget code, not PlaySound directly

Status: RESOLVED FIXED

Description

[Brian R. Bondy [:bbondy]]

We are currently calling PlaySound directly in widget/src/wimndows/nsWindow.cpp here:

http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindow.cpp#6140

The problem with this is that Win32's ASYNC flag isn't exactly async. This may slow down or seem to temporarily hang some computers that minimize.  Instead we should be using nsISound which has support for this via threading.

Comment 1

[Brian R. Bondy [:bbondy]]

Regarding the problem mentioned with Win32's ASYNC flag, please see Bug 498079

Comment 2

[Brian R. Bondy [:bbondy]]

Created attachment 557078 [details] [diff] [review]
Patch for calling nsISound

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 557078 [details] [diff] [review]
Patch for calling nsISound

We should probably cache sound so we only have to create it once.

Comment 4

[Brian R. Bondy [:bbondy]]

We are currently doing that everywhere we play sound. 
Bug 683184 will address this by making it a service. 
So is it OK as is until Bug 683184?

Comment 5

[Brian R. Bondy [:bbondy]]

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=38dc50c1c180

Comment 6

[Brian R. Bondy [:bbondy]]

Jim mentioned that Comment 4 sounded good by the way on irc.

Comment 7

[Brian R. Bondy [:bbondy]]

Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/9401940db9d2

Comment 8

[:Ehsan Akhgari (needinfo please, extremely long backlog, Away 8/18)]

http://hg.mozilla.org/mozilla-central/rev/9401940db9d2