683205 - Create reftests for RLE8 BMPs

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Brian R. Bondy [:bbondy]]

Bug 600556 introduced support for ICO BMP's which contain compression by using the BMP decoder.

We should create at least one BMP and one ICO reftests for each of the following compression types for both ICO and BMP:
- BI_BITFIELDS
- BI_RLE4
- BI_RLE8

Comment 1

[Brian R. Bondy [:bbondy]]

- RLE8 should have reftests for 8BPP
- RLE4 should have reftests for 4BPP and as for 1BPP as of Bug 683610.
- BI_BITFIELDS for 16BPP and 32BPP

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: 1BPP RLE4 reference bitmap

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 557208 [details]
1BPP RLE4 reference bitmap

Is it OK to use this Microsoft BMP image (anything legal I mean) in our tree?
To see it you'll have to use Chrome.

Comment 4

[Brian R. Bondy [:bbondy]]

> To see it you'll have to use Chrome

Or FF, just not nightly, nor IE :)

Comment 5

[Joe Drew (not getting mail)]

Comment on attachment 557208 [details]
1BPP RLE4 reference bitmap

It'd be better to craft our own, and make it small too.

Comment 6

[Brian R. Bondy [:bbondy]]

OK no prob.

/me needs to re-read about RLE so I can determine what to put in the file with the hex editor.

Comment 7

[Brian R. Bondy [:bbondy]]

Attachment: Reftests for RLE8 BMPs

I'll add in another patch for RLE4 BMPs and RLE1 BMPs once I figure out how to generate them.

Comment 8

[Brian R. Bondy [:bbondy]]

Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/e2b6064a04ff

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/e2b6064a04ff