Create reftests for RLE8 BMPs

RESOLVED FIXED in mozilla12

Status

()

Core
ImageLib
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

(Blocks: 1 bug)

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

6.62 KB, application/octet-stream
Joe Drew (not getting mail)
: feedback-
Details
5.01 KB, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Bug 600556 introduced support for ICO BMP's which contain compression by using the BMP decoder.

We should create at least one BMP and one ICO reftests for each of the following compression types for both ICO and BMP:
- BI_BITFIELDS
- BI_RLE4
- BI_RLE8
(Assignee)

Comment 1

6 years ago
- RLE8 should have reftests for 8BPP
- RLE4 should have reftests for 4BPP and as for 1BPP as of Bug 683610.
- BI_BITFIELDS for 16BPP and 32BPP
(Assignee)

Comment 2

6 years ago
Created attachment 557208 [details]
1BPP RLE4 reference bitmap
(Assignee)

Comment 3

6 years ago
Comment on attachment 557208 [details]
1BPP RLE4 reference bitmap

Is it OK to use this Microsoft BMP image (anything legal I mean) in our tree?
To see it you'll have to use Chrome.
Attachment #557208 - Flags: feedback?(joe)
(Assignee)

Comment 4

6 years ago
> To see it you'll have to use Chrome

Or FF, just not nightly, nor IE :)
Comment on attachment 557208 [details]
1BPP RLE4 reference bitmap

It'd be better to craft our own, and make it small too.
Attachment #557208 - Flags: feedback?(joe) → feedback-
(Assignee)

Comment 6

6 years ago
OK no prob.

/me needs to re-read about RLE so I can determine what to put in the file with the hex editor.
(Assignee)

Comment 7

5 years ago
Created attachment 584951 [details] [diff] [review]
Reftests for RLE8 BMPs

I'll add in another patch for RLE4 BMPs and RLE1 BMPs once I figure out how to generate them.
Attachment #584951 - Flags: review?(joe)
Attachment #584951 - Flags: review?(joe) → review+
(Assignee)

Comment 8

5 years ago
Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/e2b6064a04ff
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/e2b6064a04ff
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Summary: Create reftests for newly supported ICO BMPs which have compression → Create reftests for RLE8 BMPs
(Assignee)

Updated

5 years ago
Blocks: 715128
You need to log in before you can comment on or make changes to this bug.