Last Comment Bug 683275 - Geolocation should avoid triggering a remote prompt if the testing pref is set
: Geolocation should avoid triggering a remote prompt if the testing pref is set
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Geolocation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Josh Matthews [:jdm]
:
Mentors:
Depends on:
Blocks: 682416
  Show dependency treegraph
 
Reported: 2011-08-30 12:55 PDT by Josh Matthews [:jdm]
Modified: 2012-09-14 03:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Check the testing pref for geolocation first regardless of which process is requesting the prompt. (1.87 KB, patch)
2011-08-30 12:57 PDT, Josh Matthews [:jdm]
dougt: review+
Details | Diff | Review

Description Josh Matthews [:jdm] 2011-08-30 12:55:51 PDT
The code is backwards as written.
Comment 1 Josh Matthews [:jdm] 2011-08-30 12:57:08 PDT
Created attachment 556959 [details] [diff] [review]
Check the testing pref for geolocation first regardless of which process is requesting the prompt.
Comment 3 Ed Morley [:emorley] 2011-09-01 01:35:00 PDT
http://hg.mozilla.org/mozilla-central/rev/bf95c7aab462
Comment 4 Ed Morley [:emorley] 2012-09-14 03:07:23 PDT
(Clearing to stop this request showing up on the 'My Requests' page)

Note You need to log in before you can comment on or make changes to this bug.