Closed Bug 683351 Opened 13 years ago Closed 6 years ago

ANI: VM should provide support for getting class Traits

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: rulohani, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently PlayerToplevel provides methods to get the class traits given the class id. This functionality should move to VM. Client should be able to get the traits using the ClassManifest.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #557025 - Flags: feedback?(rreitmai)
Attachment #557025 - Flags: feedback?(rreitmai) → review?(rreitmai)
Attachment #557025 - Flags: review?(rreitmai) → review+
Attachment #557025 - Flags: superreview?(edwsmith)
Attached patch Patch v2Splinter Review
Had missed the point that the ClassManifestBase will be exactly traced.
Attachment #557025 - Attachment is obsolete: true
Attachment #557025 - Flags: superreview?(edwsmith)
Attachment #557685 - Flags: superreview?(edwsmith)
Attachment #557685 - Flags: review?(rreitmai)
Flags: flashplayer-qrb+
Flags: flashplayer-bug-
Target Milestone: --- → Future
Attachment #557685 - Flags: review?(rreitmai) → review+
Its kinda weird that getClassTraits returns the instance traits, shouldn't we return the ctraits and let them get itraits from that if that's what they want? Also do we need to store them in a list? The pool's array seems like sufficient storage to me.
Comment on attachment 557685 [details] [diff] [review] Patch v2 cancelling SR until we ressurrect this.
Attachment #557685 - Flags: superreview?(edwsmith)
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: