68338 - Changes to MRJ plugin LiveConnect native methods

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect)

Description

[Patrick C. Beard]

Here are some changes that are necessary to keep the MRJ plugin compiling with 
the proposed changes in bug # 63466, mainly the change to the nsILiveconnect 
interface. Interestingly, changing the type of the securityContext parameter to 
nsISupports uncovered some incorrect parameter passing bugs in the code.

Comment 1

[Patrick C. Beard]

Attachment: Enhancements to MRJ plugin's LiveConnect native methods.

Comment 2

[Patrick C. Beard]

Attachment: Revised project file, adds weak linkage to xpcom to call NS_GetGlobalComponentManager

Comment 3

[Brendan Eich [:brendan]]

Do we require super-review for this plugin?  I guess so, if it's "in process"
and all that (http://www.mozilla.org/hacking/reviewers.html).

diff -u is my friend.

Nominating for 0.8.

Who should review?

/be

Comment 4

[Brendan Eich [:brendan]]

Noting dependency, updating status whiteboard.

Patrick, can you ASSIGN this bug and set Target Milestone, in addition to
attaching a diff -u patch?  Thanks,

/be

Comment 5

[Patrick C. Beard]

Attachment: diff -u for better comprehension

Comment 6

[Brendan Eich [:brendan]]

Wow, is this a non-standard C++ extension for "weak linking"?

+    if (&NS_GetGlobalComponentManager) {
+        NS_GetGlobalComponentManager(&theComponentManager);
+    }

How about using nsCOMPtr and do_GetService here, instead of kickin' it old school?

+    nsIIOService* ioService;
+    static NS_DEFINE_CID(kIOServiceCID, NS_IOSERVICE_CID);
+    nsresult rv = theServiceManager->GetService(kIOServiceCID,
NS_GET_IID(nsIIOService), (nsISupports**)&ioService);
+    if (rv == NS_OK)
+        rv = ioService->NewURI(spec, baseURI, result);
+    NS_RELEASE(ioService);

Otherwise, looks ok to me.

Does this void* to nsISupports* change mean Sun's JVM plugin, and any others,
also need to change?  I.e., aren't you changing a part of the OJI for all JVMs
that support LiveConnect?

/be

Comment 7

[Patrick C. Beard]

Changes landed on trunk. Will land on 0.8 branch tomorrow.

Comment 8

[Asa Dotzler [:asa]]

has this landed on the branch?  I saw a checkin with bug 63466 in the comment 
but I didn't see a checkin comment with this bug #.

Comment 9

[Asa Dotzler [:asa]]

Actually, it looks like this did make it into the branch and it's bug 63466's
patch that did not make it in.

Comment 10

[Asa Dotzler [:asa]]

sorry for all the spam (it was well intentioned), cleaning up whiteboard,
patches for both of these bugs did make it into the 0.8 branch.

Comment 11

[Patrick C. Beard]

This stuff was checked in.

Comment 12

[John Unruh]

Verified per beard's comments.