Changes to MRJ plugin LiveConnect native methods

VERIFIED FIXED in mozilla0.8.1

Status

VERIFIED FIXED
18 years ago
8 years ago

People

(Reporter: beard, Assigned: beard)

Tracking

Trunk
mozilla0.8.1
PowerPC
Mac System 9.x

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

18 years ago
Here are some changes that are necessary to keep the MRJ plugin compiling with 
the proposed changes in bug # 63466, mainly the change to the nsILiveconnect 
interface. Interestingly, changing the type of the securityContext parameter to 
nsISupports uncovered some incorrect parameter passing bugs in the code.
(Assignee)

Comment 1

18 years ago
Created attachment 24913 [details] [diff] [review]
Enhancements to MRJ plugin's LiveConnect native methods.
(Assignee)

Comment 2

18 years ago
Created attachment 24914 [details]
Revised project file, adds weak linkage to xpcom to call NS_GetGlobalComponentManager
Do we require super-review for this plugin?  I guess so, if it's "in process"
and all that (http://www.mozilla.org/hacking/reviewers.html).

diff -u is my friend.

Nominating for 0.8.

Who should review?

/be
Keywords: mozilla0.8
Noting dependency, updating status whiteboard.

Patrick, can you ASSIGN this bug and set Target Milestone, in addition to
attaching a diff -u patch?  Thanks,

/be
Depends on: 63466
Whiteboard: critical to mozilla0.8
(Assignee)

Comment 5

18 years ago
Created attachment 24924 [details] [diff] [review]
diff -u for better comprehension
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.8
Wow, is this a non-standard C++ extension for "weak linking"?

+    if (&NS_GetGlobalComponentManager) {
+        NS_GetGlobalComponentManager(&theComponentManager);
+    }

How about using nsCOMPtr and do_GetService here, instead of kickin' it old school?

+    nsIIOService* ioService;
+    static NS_DEFINE_CID(kIOServiceCID, NS_IOSERVICE_CID);
+    nsresult rv = theServiceManager->GetService(kIOServiceCID,
NS_GET_IID(nsIIOService), (nsISupports**)&ioService);
+    if (rv == NS_OK)
+        rv = ioService->NewURI(spec, baseURI, result);
+    NS_RELEASE(ioService);

Otherwise, looks ok to me.

Does this void* to nsISupports* change mean Sun's JVM plugin, and any others,
also need to change?  I.e., aren't you changing a part of the OJI for all JVMs
that support LiveConnect?

/be
(Assignee)

Comment 7

18 years ago
Changes landed on trunk. Will land on 0.8 branch tomorrow.

Comment 8

18 years ago
has this landed on the branch?  I saw a checkin with bug 63466 in the comment 
but I didn't see a checkin comment with this bug #.

Comment 9

18 years ago
Actually, it looks like this did make it into the branch and it's bug 63466's
patch that did not make it in.

Comment 10

18 years ago
sorry for all the spam (it was well intentioned), cleaning up whiteboard,
patches for both of these bugs did make it into the 0.8 branch.
Whiteboard: critical to mozilla0.8

Updated

18 years ago
Target Milestone: mozilla0.8 → mozilla0.8.1

Updated

18 years ago
Keywords: mozilla0.8
(Assignee)

Comment 11

18 years ago
This stuff was checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 12

18 years ago
Verified per beard's comments.
Status: RESOLVED → VERIFIED
QA Contact: shrir → junruh

Updated

8 years ago
Component: Java: OJI → Java: OJI
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.