Closed
Bug 683403
Opened 14 years ago
Closed 14 years ago
rm JS_LONE_INTERPRET
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
7.83 KB,
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
/*
* JS_LONE_INTERPRET indicates that the compiler should see just the code for
* the js_Interpret function when compiling jsinterp.cpp. The rest of the code
* from the file should be visible only when compiling jsinvoke.cpp. It allows
* platform builds to optimize selectively js_Interpret when the granularity
* of the optimizations with the given compiler is a compilation unit.
*/
A GCC shell build on SS/V8 and a Win32 Talos build on SS/Dromaeo/Ts/etc does not show any speedup from JS_LONE_INTERPRET. Since this is really pretty strange and I have seen it frustrate several newcomers ("why can't Interpret see my function declaration?!"), it would be nice to remove.
Attachment #557052 -
Flags: review?(igor)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 557052 [details] [diff] [review]
rm JS_LONE_INTERPRET
Yes, it is time to remove this.
Attachment #557052 -
Flags: review?(igor) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Whiteboard: [inbound]
|
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•