The default bug view has changed. See this FAQ.

rm JS_LONE_INTERPRET

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 557052 [details] [diff] [review]
rm JS_LONE_INTERPRET

/*
 * JS_LONE_INTERPRET indicates that the compiler should see just the code for
 * the js_Interpret function when compiling jsinterp.cpp. The rest of the code
 * from the file should be visible only when compiling jsinvoke.cpp. It allows
 * platform builds to optimize selectively js_Interpret when the granularity
 * of the optimizations with the given compiler is a compilation unit.
 */

A GCC shell build on SS/V8 and a Win32 Talos build on SS/Dromaeo/Ts/etc does not show any speedup from JS_LONE_INTERPRET.  Since this is really pretty strange and I have seen it frustrate several newcomers ("why can't Interpret see my function declaration?!"), it would be nice to remove.
Attachment #557052 - Flags: review?(igor)

Comment 1

6 years ago
Comment on attachment 557052 [details] [diff] [review]
rm JS_LONE_INTERPRET

Yes, it is time to remove this.
Attachment #557052 - Flags: review?(igor) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/8f345f65a9a0
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/8f345f65a9a0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.