68341 - Account Settings: Needs mnemonics

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Ninoschka Baca]

Build 2001-02-09-04: NT4, Linux RH 6.2

Overview: The Account Settings dialogs have no mnemonics.

Expected Results: According to the Account Setup spec there should be mnemonics
in the Account Settings panels (i.e. Account Settings, Server Settings, Copies
and Folders Settings)

Comment 1

[Ninoschka Baca]

Marking nsbeta1 for accessibility reasons.

Comment 2

[scottputterman]

marking nsbeta1-. This sounds like a potential post beta bug.

Comment 3

[Stephen Walker]

jglick, can you update the spec for the Account Manager? Using `H' as the 
accesskey for the `Check new messages...' isn't available anymore since it's 
being using for the `Help' button. 

When trying to fix this bug I also ran into problems where labels, for instance 
the `Use secure connection (SSL)' label, used different accesskeys in different 
types of accounts. It uses `T' in POP and IMAP, but switches to `O' in NNTP. 
This is a problem because the label and the accesskey are only defined once in 
the .dtd, so only one accesskey can be used. Even worse is the `Local 
directory:' label which uses a different accesskey in each type of account. The 
problem could be fixed by making labels that are the same with different 
accesskeys, but being consistent and using the same accesskey across all 
accounts seems better to me.

Comment 4

[jglick]

Updated spec should show up shortly. If i missed anything, let me know.

Comment 5

[Jessie Li]

Attachment: patch

This patch is based on the Specs:
http://www.mozilla.org/mailnews/specs/accounts/

But some accesskeys are modified according to the accesskey guildlines.
http://www.mozilla.org/projects/ui/accessibility/accesskey.html

Comment 6

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 7

[Stefan Borggraefe]

Comment on attachment 119280 [details] [diff] [review]
patch 

I just tried this patch. It doesn't apply anymore and needs to be updated. :-(

Comment 8

[Stefan Borggraefe]

I just tried to fix this bug and then realized, that without bug 143065 fixed,
there are not enough characters in the alphabet to assign a unique key to every
control.

So this bug is blocked by bug 143065.

Comment 9

[[e-mail]]

I disagree. These panels are pages, not tabpanels, so the only thing you have to
be careful of are the add/default/remove buttons.

Comment 10

[Stefan Borggraefe]

Neil is right. I made a mistake when I tried this.

Taking bug.

Comment 11

[Stefan Borggraefe]

Attachment: Updated patch

I also removed some unused strings where I spotted them.

Comment 12

[Stefan Borggraefe]

Attachment: Updated once again

Comment 13

[Stefan Borggraefe]

Attachment: Updated to reflect a change in bug 40759

I just changed the accesskey for "&Leave in my Inbox" to "Leave in my &Inbox"
to make this consistent with the keys used in bug 40759.

Comment 14

[[e-mail]]

Comment on attachment 136492 [details] [diff] [review]
Updated to reflect a change in bug 40759

>   <button id="encryptionCertClearButton"
>-          label="&certificate_clear.button;"
>+          label="&encryption.certificate_clear.button;"
>+          accesskey="&encryption.certificate_clear.button.accesskey;"
Ideally, just encryption.certificate_clear.accesskey (and similarly in other
places) will do.

Other nits (with no particular reference):
&Expunge
Automatically &quote
(you can ignore/remove menulist item access keys)
Set De&fault (to match account manager)
Server supports &folders
Personal &namespace
&Public
That's assuming that I've not introduced new conflicts, of course ;-)

Comment 15

[Stefan Borggraefe]

Attachment: Addressed review comments

>Ideally, just encryption.certificate_clear.accesskey (and similarly in
>other places) will do.
>&Expunge
>Automatically &quote
>(you can ignore/remove menulist item access keys)
>Set De&fault (to match account manager)
>Server supports &folders

Done.

>Personal &namespace
>&Public

This is not possible because the accesskey "n" matches Perso&nal. So I left
these two as they were in the last patch.

I also found and fixed another small bug in am-addressing.xul: The control
attributes of the labels left from the drop-down menus were wrong ("Then," and
"place my signature"). So the access keys for these menus were not working.

Comment 16

[Stefan Borggraefe]

Attachment: Patch for Thunderbird

This needs to be checked in for TB so the Account Manager does not break there.

Comment 17

[Stefan Borggraefe]

Comment on attachment 136527 [details] [diff] [review]
Addressed review comments

Requesting approval for 1.6b. This adds access keys to all panels and child
dialogs of the Account Settings. Low risk.

David: Could you check this in for me if/when this gets approved?

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 136527 [details] [diff] [review]
Addressed review comments

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 19

[David :Bienvenu]

I can check this in later this afternoon, along with the thunderbird patch.

Comment 20

[David :Bienvenu]

fixes checked in.