683422 - An Ampersand (&) on the URL line breaks Translate Page

Status: RESOLVED FIXED

Description

[therube]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20110820 Firefox/6.0 SeaMonkey/2.3.1
Build ID: 20110820145925

Steps to reproduce:

 
URL: http://forums.mozillazine.org/viewtopic.php?f=3&t=2183189
Tools | Translate Page
 


Actual results:

 
The URL sent to Google Translate is truncated.
All characters after the ampersand are lost.
Google is not able to translate the page.
 


Expected results:

 
The entire URL should be passed to Google Translate.
Google should then translate the page for you.
 
 
It is quite common, for forums in particular, to use an (&) in their URL line.
Attempting to translate them from Tools | Translate breaks - often.

The same URLs manually pasted into http://translate.google.com/ work as the URL is not modified.

URL encoding the (&) would not appear to be a solution as it seems Google does not decode it back to what would be valid for a particular forum.

Don't know if there could be any security concerns in passing the full URL in plain text?
 

Some examples that break:

http://www.pcqanda.com/dc/dcboard.php?az=show_topic&forum=2&topic_id=535822&mesg_id=535822&page=

> http://www.pcqanda.com/dc/dcboard.php?az=show_topic

http://forums.mozillazine.org/viewtopic.php?f=3&t=2183189

> http://forums.mozillazine.org/viewtopic.php?f=3

http://forums.informaction.com/viewtopic.php?f=7&t=6997

> http://forums.informaction.com/viewtopic.php?f=7

http://www.digitalvolcano.co.uk/board/viewtopic.php?f=4&t=699

> http://www.digitalvolcano.co.uk/board/viewtopic.php?f=4

Comment 1

[therube]

Actually it /appears/ to start out well, but in reality at the first GET the Query String has already been truncated.
 
 
00:00:05.933	0.213	741	663	GET	200	text/html	http://translate.google.com/translate?prev=/language_tools&u=http://forums.mozillazine.org/viewtopic.php?f=3&t=2183189
00:00:06.188	0.153	866	2298	GET	200	text/html	http://translate.google.com/translate_n?prev=/language_tools&u=http://forums.mozillazine.org/viewtopic.php%3Ff%3D3
00:00:06.223	0.151	905	623	GET	200	text/html	http://translate.google.com/translate_p?prev=/language_tools&u=http://forums.mozillazine.org/viewtopic.php%3Ff%3D3&usg=ALkJrhh4jDayGH1J4kj0mT50Bu9FTK4KaQ
00:00:06.747	0.073	602	0	GET	(Aborted)	NS_BINDING_ABORTED	http://translate.googleusercontent.com/translate_c?prev=/language_tools&rurl=translate.google.com&u=http://forums.mozillazine.org/viewtopic.php%3Ff%3D3&usg=ALkJrhg2CLySXVGgBYpqLJmmg5eLm0QiJg
00:00:06.867	0.040	766	0	GET	(Error)	NS_ERROR_ABORT	http://translate.googleusercontent.com/translate_c?prev=/language_tools&rurl=translate.google.com&u=http://forums.mozillazine.org/viewtopic.php%3Ff%3D3&usg=ALkJrhg2CLySXVGgBYpqLJmmg5eLm0QiJg

Comment 2

[Philip Chee]

function Translate()
{
  var service = GetLocalizedStringPref("browser.translation.service");
  var serviceDomain = GetLocalizedStringPref("browser.translation.serviceDomain");
  var targetURI = getWebNavigation().currentURI.spec;

  // if we're already viewing a translated page, then just reload
  if (targetURI.indexOf(serviceDomain) >= 0)
    BrowserReload();
  else {
    loadURI(encodeURI(service + targetURI));
  }
}

The following works for me:
loadURI(encodeURI(service) + encodeURIComponent(targetURI));
Neil is this the correct fix?

Comment 3

[Philip Chee]

Created attachment 557493 [details] [diff] [review]
Patch v1.0 use encode

Comment 4

[Philip Chee]

Pushed.
http://hg.mozilla.org/comm-central/rev/1a07f47df164

Comment 5

[Philip Chee]

Comment on attachment 557493 [details] [diff] [review]
Patch v1.0 use encode

Simple one line fix.

Comment 6

[Philip Chee]

Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/27805def8a85
http://hg.mozilla.org/releases/comm-beta/rev/54f2d228378e