Closed Bug 683448 Opened 9 years ago Closed 8 years ago

Permission check and virus scan tests shouldn't fail if files pushed to the releases directory

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [releases][automation])

Attachments

(2 files, 5 obsolete files)

Hit in 3.6.21 and 7.0b3 releases when files were pushed before permission check and virus scan tests started running dry run rsync command. As a result the following check failed:

 test ! -d /pub/mozilla.org/firefox/releases/3.6.21/
Attachment #557102 - Flags: review?(bhearsum)
Comment on attachment 557102 [details] [diff] [review]
don't test release directory in dry run mode

Review of attachment 557102 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is a perfectly valid check to be doing in both dry run and non dry run modes. In normal situations, everything is perfectly fine, too. You suggested making it a warning instead of an error - which would be perfectly fine with me, but I don't want to stop running it in dry run mode altogether.
Attachment #557102 - Flags: review?(bhearsum) → review-
Attachment #557102 - Attachment is obsolete: true
Attachment #557424 - Flags: review?(bhearsum)
Tested in staging. Got orange check permissions/av steps when the directory exists.
Attachment #557425 - Flags: review?(bhearsum)
BTW, do you want me to symlink push-to-miirors.sh to check-permissions.sh and run-av.sh (or something similar) and run those command from release.py instead of push-to-miirors.sh to prevent heart attacks? :)
Attachment #557424 - Flags: review?(bhearsum) → review+
Comment on attachment 557425 [details] [diff] [review]
Add "WARN(ING)?:" pattern as WARNINGS

Review of attachment 557425 [details] [diff] [review]:
-----------------------------------------------------------------

Please don't land this until after chemspills.
Attachment #557425 - Flags: review?(bhearsum) → review+
Comment on attachment 557424 [details] [diff] [review]
fail/warn depending on dry run

http://hg.mozilla.org/build/tools/rev/459f3d9fd735
Attachment #557424 - Flags: checked-in+
Comment on attachment 557425 [details] [diff] [review]
Add "WARN(ING)?:" pattern as WARNINGS

http://hg.mozilla.org/build/buildbotcustom/rev/cae841f5896a
Attachment #557425 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Merged to production and reconfigured.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 557425 [details] [diff] [review]
Add "WARN(ING)?:" pattern as WARNINGS

this caused widespread orange (bug 685180)
Attachment #557425 - Flags: checked-in+ → checked-in-
Attached patch Use more specific matching (obsolete) — Splinter Review
Attachment #558910 - Flags: review?(catlee)
Attached patch Use more specific matching (obsolete) — Splinter Review
Attachment #557425 - Attachment is obsolete: true
Attachment #558910 - Attachment is obsolete: true
Attachment #558910 - Flags: review?(catlee)
Attachment #558912 - Flags: review?(catlee)
Attachment #558912 - Flags: review?(catlee)
Should add a local function and not use global regexps.
Attached patch Use regex_log_evaluator (obsolete) — Splinter Review
To be tested
Attachment #558912 - Attachment is obsolete: true
Summary: Permission check and virus scan tests should fail if files pushed to the releases directory → Permission check and virus scan tests shouldn't fail if files pushed to the releases directory
Passed staging tests.
Attachment #567457 - Attachment is obsolete: true
Attachment #567927 - Flags: review?(catlee)
Attachment #567927 - Flags: review?(catlee) → review+
A reconfig that included this happened today.
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.