683448 - Permission check and virus scan tests shouldn't fail if files pushed to the releases directory

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

Hit in 3.6.21 and 7.0b3 releases when files were pushed before permission check and virus scan tests started running dry run rsync command. As a result the following check failed:

 test ! -d /pub/mozilla.org/firefox/releases/3.6.21/

Comment 1

[Rail Aliiev [:rail]]

Attachment: don't test release directory in dry run mode

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 557102 [details] [diff] [review]
don't test release directory in dry run mode

Review of attachment 557102 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is a perfectly valid check to be doing in both dry run and non dry run modes. In normal situations, everything is perfectly fine, too. You suggested making it a warning instead of an error - which would be perfectly fine with me, but I don't want to stop running it in dry run mode altogether.

Comment 3

[Rail Aliiev [:rail]]

Attachment: fail/warn depending on dry run

Comment 4

[Rail Aliiev [:rail]]

Attachment: Add "WARN(ING)?:" pattern as WARNINGS

Tested in staging. Got orange check permissions/av steps when the directory exists.

Comment 5

[Rail Aliiev [:rail]]

BTW, do you want me to symlink push-to-miirors.sh to check-permissions.sh and run-av.sh (or something similar) and run those command from release.py instead of push-to-miirors.sh to prevent heart attacks? :)

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 557425 [details] [diff] [review]
Add "WARN(ING)?:" pattern as WARNINGS

Review of attachment 557425 [details] [diff] [review]:
-----------------------------------------------------------------

Please don't land this until after chemspills.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 557424 [details] [diff] [review]
fail/warn depending on dry run

http://hg.mozilla.org/build/tools/rev/459f3d9fd735

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 557425 [details] [diff] [review]
Add "WARN(ING)?:" pattern as WARNINGS

http://hg.mozilla.org/build/buildbotcustom/rev/cae841f5896a

Comment 9

[Armen [:armenzg]]

Merged to production and reconfigured.

Comment 10

[Chris AtLee [:catlee]]

Comment on attachment 557425 [details] [diff] [review]
Add "WARN(ING)?:" pattern as WARNINGS

this caused widespread orange (bug 685180)

Comment 11

[Rail Aliiev [:rail]]

Attachment: Use more specific matching

Comment 12

[Rail Aliiev [:rail]]

Attachment: Use more specific matching

Comment 13

[Rail Aliiev [:rail]]

Should add a local function and not use global regexps.

Comment 14

[Rail Aliiev [:rail]]

Attachment: Use regex_log_evaluator

To be tested

Comment 15

[Rail Aliiev [:rail]]

Attachment: Use regex_log_evaluator

Passed staging tests.

Comment 16

[Rail Aliiev [:rail]]

Comment on attachment 567927 [details] [diff] [review]
Use regex_log_evaluator

http://hg.mozilla.org/build/buildbotcustom/rev/8f56de92092e

Comment 17

[Chris Cooper [:coop] (he/him)]

A reconfig that included this happened today.