68348 - Command+Period shortcut not shown for Stop in View menu

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[sairuh (rarely reading bugmail)]

spun off from bug 64718. the shortcut for Stop in the View menu isn't listed on
the Mac. in 4.x it was Command+period --not sure if we should follow this
convention, or use what unix.win32, which is Esc. [esc does work on the Mac,
though.]

Comment 1

[Matthew T (active 1999-2002)]

Command+. is more Mac-like, but Esc is easier to hit. I vote for showing Esc 
(while still supporting Command+.).

Comment 2

[Paul Chen]

nav triage team:

Reassign to saari so that he can tell us how to fix this. Then reassign back to 
pchen.

Comment 3

[saari (gone)]

If it doesn't just work like all the other menus, then period is a special
character and has to be dealt with seperately like arrow keys and friends. The
mac code has not been written to do this yet.

Comment 4

[Gervase Markham [:gerv]]

Are people still seeing this? 

NavigatorOverlay.xul says:
        <menuitem label="&stopCmd.label;" accesskey="&stopCmd.accesskey;"
id="menuitem-stop" oncommand="BrowserStop();" key="key_stop"/>

key_stop is:
<key id="key_stop" keycode="VK_ESCAPE" oncommand="BrowserStop();"/>

All this is supposedly XP. So I have no idea why it wouldn't show up on the Mac.

Gerv

Comment 5

[Frankie]

Still occurs in 20030311 OSX. Does the Esc key have a recognized character
equivalent in MacOS?

Comment 6

[Asaf Romano (gone)]

Most mac browsers show Command+Period (Safari, Camino, MacIE), we should do the
same.

Comment 7

[Asaf Romano (gone)]

Attachment: v1: show command+. on mac (and move key_stop to platfrom keybindings)

per last comment.

Comment 8

[jhp (no longer active)]

Comment on attachment 171755 [details] [diff] [review]
v1: show command+. on mac (and move key_stop to platfrom keybindings)

I can't vouch for Win32 or Unix, but it works great on the Mac.  Have you
tested on those other platforms?

Comment 9

[Asaf Romano (gone)]

(In reply to comment #8)
> (From update of attachment 171755 [details] [diff] [review] [edit])
> I can't vouch for Win32 or Unix, but it works great on the Mac.  Have you
> tested on those other platforms?
> 

No, but if there are no typos, it should work (just like the back/forward
keybindings).

Comment 10

[[e-mail]]

Comment on attachment 171755 [details] [diff] [review]
v1: show command+. on mac (and move key_stop to platfrom keybindings)

Seems to work on Linux.

Comment 11

[Asaf Romano (gone)]

checked in by timeless.