683618 - synthetic bolding on Android (gfxFT2Fonts) does not adjust glyph metrics properly

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Kew [:jfkthame]]

When we use double-striking (with an offset) to simulate bold for font families that don't have a real bold face, we're supposed to add a corresponding delta to the glyph advances, so as to maintain reasonable inter-glyph spacing.

However, the code in gfxFT2Font::InitTextRun() calls AdjustAdvancesForSyntheticBold in the wrong place, with the result that it doesn't have any effect. This means that synthetic-bold glyphs appear crowded together, as can be seen in the test case at http://people.mozilla.com/~jkew/synbold.html; this is particularly noticeable when the page is zoomed out, so that the font size is small.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: patch, move AdjustAdvancesForSyntheticBold to the right place

With this patch, the synthetic-bold text in the testcase looks much better and more readable, as it has proper inter-glyph spacing.

Comment 2

[John Daggett (:jtd)]

Comment on attachment 557202 [details] [diff] [review]
patch, move AdjustAdvancesForSyntheticBold to the right place

Yeah, I was wondering about this when looking at bug 674909.

Comment 3

[Jonathan Kew [:jfkthame]]

Incidentally, we already have a reftest that checks this (layout/reftests/text/synthetic-bold-metrics-01.html), but it's marked as failing on android - on a tryserver run with this patch, it "unexpectedly" passes. :)

Comment 4

[Jonathan Kew [:jfkthame]]

Pushed to inbound, including updating the reftest manifest because the test now passes:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c1281875cfea

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/c1281875cfea