683654 - Make TraceVis compile and run again.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: Minimal fix to make TraceVis run again.

It appears to have bitrotted and needs some minor fixes to compile.

Comment 1

[David Mandelin [:dmandelin]]

Comment on attachment 557261 [details] [diff] [review]
Minimal fix to make TraceVis run again.

Review of attachment 557261 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks OK. I wouldn't bother working too much on this, though, because IonMonkey is expected to replace the existing JITs.

Comment 2

[Terrence Cole [:terrence]]

Agreed, and thank you for the review!  I wanted to give it a look to get ideas for implementing similar tracing on the GC.  Consensus in IRC was that I should submit the patch despite my reservations, since I already had it working.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Terrence Cole from comment #2)
> Agreed, and thank you for the review!  I wanted to give it a look to get
> ideas for implementing similar tracing on the GC.  Consensus in IRC was that
> I should submit the patch despite my reservations, since I already had it
> working.

Hi Terrence. Let me know what your plans are for this. I have some tools that I've been working on too.

Comment 4

[Ed Morley [:emorley]]

In my queue :-)

Comment 5

[Ed Morley [:emorley]]

As mentioned in bug 646597, the first try run was busted by bug 682677's patch, and now the second has failed, likely due to bug 646597:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=ddfa68e986d8

I've sent this to try again, and presuming green this time (third time lucky!), will push to inbound after:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=c902a63fb74c

Comment 6

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/bcc474c726aa

Comment 7

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/bcc474c726aa