Make TraceVis compile and run again.

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 557261 [details] [diff] [review]
Minimal fix to make TraceVis run again.

It appears to have bitrotted and needs some minor fixes to compile.
Attachment #557261 - Flags: review?(dmandelin)
Comment on attachment 557261 [details] [diff] [review]
Minimal fix to make TraceVis run again.

Review of attachment 557261 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks OK. I wouldn't bother working too much on this, though, because IonMonkey is expected to replace the existing JITs.
Attachment #557261 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 2

6 years ago
Agreed, and thank you for the review!  I wanted to give it a look to get ideas for implementing similar tracing on the GC.  Consensus in IRC was that I should submit the patch despite my reservations, since I already had it working.
Keywords: checkin-needed
(In reply to Terrence Cole from comment #2)
> Agreed, and thank you for the review!  I wanted to give it a look to get
> ideas for implementing similar tracing on the GC.  Consensus in IRC was that
> I should submit the patch despite my reservations, since I already had it
> working.

Hi Terrence. Let me know what your plans are for this. I have some tools that I've been working on too.

Comment 4

6 years ago
In my queue :-)
Assignee: general → terrence
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 5

6 years ago
As mentioned in bug 646597, the first try run was busted by bug 682677's patch, and now the second has failed, likely due to bug 646597:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=ddfa68e986d8

I've sent this to try again, and presuming green this time (third time lucky!), will push to inbound after:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=c902a63fb74c

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/bcc474c726aa
Target Milestone: --- → mozilla9

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/bcc474c726aa
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.