I have an unminimized testcase with this crash stack: https://crash-stats.mozilla.com/report/index/bp-184613e9-30b4-4e36-a653-a75352110831 0 xul.dll CalcQuirkContainingBlockHeight layout/generic/nsHTMLReflowState.cpp:1548 1 xul.dll nsHTMLReflowState::InitConstraints 2 xul.dll nsTArray<nsIFrame*,nsTArrayDefaultAllocator>::Clear obj-firefox/dist/include/nsTArray.h:886 3 xul.dll nsStyleContext::DoGetStylePadding obj-firefox/dist/include/nsStyleStructList.h:139 4 xul.dll nsHTMLReflowState::Init layout/generic/nsHTMLReflowState.cpp:282 Dumping it here, maybe someone can fix it by looking at the stack.
Is it a regression?
It's also happening in a 2011-08-24 build, so it's not a regression from bug 679933. I'll try to get a testcase next week or so.
It's a null deref crash on this code: rs->parentReflowState->frame->GetType() rs is known-null here, so I would guess rs->parentReflowState is null. Martijn, can you attach the unminimized testcase? Might well be fixable from that.
http://www.mxgraph.com/demo/markup/webkitbg.html Nightly, Aurora, Beta - Linux, Mac, Windows.
Bob, thanks! As expected, rs->parentReflowState is null. rs->frame->mContent is a nsSVGForeignObjectElement, and rs->frame is correctly an nsBlockFrame. Sounds like our basic assumption here is that an nsBlockFrame can't be a reflow root, and that's just not true. We probably just need to add a null-check for rs->parentReflowState.
Created attachment 572392 [details] [diff] [review] Add a null-check to avoid bogus assumptions about blocks not being reflow roots.
6 years ago
Shouldn't the fixed height of a foreignObject be relevant when computing percentage heights on its kids? (If it is, why are we in this code?)
> Shouldn't the fixed height of a foreignObject be relevant when computing percentage > heights on its kids? It is, but in this case we have a percent-height kid of an auto height kid of the <foreignObject>. And the page is in quirks mode, so the innermost block ends up in CalcQuirkContainingBlockHeight. Or did I misunderstand your question?