683725 - release mail should be threadable

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P5)

Description

[[e-mail] (:bhearsum)]

It would help readability if release mail set In-Reply-To or References to something consistent across a release, so that mail clients could thread it

Comment 1

[[e-mail] (:bhearsum)]

Mass move of bugs to Release Automation component.

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: patch for emeail threading

Patch for email threading

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 672853 [details] [diff] [review]
patch for emeail threading

http://hg.mozilla.org/build/buildbotcustom/rev/dd4ab12fd027

Comment 4

[Aki Sasaki (not active)]

This is live.

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 672853 [details] [diff] [review]
patch for emeail threading

Review of attachment 672853 [details] [diff] [review]:
-----------------------------------------------------------------

working well for today's release!

however, we have a minor problem where emails from production and staging are getting threaded together.

::: process/release.py
@@ +305,5 @@
>      deliverables_builders = []
>      xr_deliverables_builders = []
>      post_deliverables_builders = []
>      post_antivirus_builders = []
> +    email_message_id = hashlib.md5("%(baseTag)s %(productName)s %(version)s %(buildNumber)s" %releaseConfig).hexdigest()

I think this should be %(messagePrefix)s instead of %(baseTag)s. baseTag refers to the hg tag, and messagePrefix is [release] or [staging-release]

Comment 6

[Massimo Gervasini [:massimo]]

Attachment: refactored email_message_id

Comment 8

[Massimo Gervasini [:massimo]]

Attachment: updated message-id format

Updated Message-Id to: <"unique-string"@mozilla.com>

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 676601 [details] [diff] [review]
updated message-id format

Review of attachment 676601 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/release.py
@@ +297,5 @@
>          return bool([p for p in platforms if substring in p])
>  
> +    def getMessageId():
> +        md5 = hashlib.md5(getMessageTag())
> +        for key in ("version", "buildNumber", "platform"):

"platform" should be "productName"

Comment 10

[Massimo Gervasini [:massimo]]

Attachment: replaced "platform" with "productName" in getMessageId()

Comment 11

[[e-mail] (:bhearsum)]

In production.

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum [:bhearsum] from comment #11)
> In production.