Closed
Bug 683729
Opened 13 years ago
Closed 13 years ago
GCC 4.6 build warning: "js/src/vm/Debugger.cpp:874:11: warning: variable ‘frame’ set but not used [-Wunused-but-set-variable]"
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
968 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Filing bug on this build warning:
> js/src/vm/Debugger.cpp: In static member function ‘static JSTrapStatus js::Debugger::onTrap(JSContext*, js::Value*)’:
> js/src/vm/Debugger.cpp:874:11: warning: variable ‘frame’ set but not used [-Wunused-but-set-variable]
The variable is declared like so...
> 874 Value frame = UndefinedValue();
https://mxr.mozilla.org/mozilla-central/source/js/src/vm/Debugger.cpp#874
...and is never used after that. (That's actually been the case since its first checkin: https://hg.mozilla.org/mozilla-central/rev/45f1cf2c59d2#l63.306 )
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #557328 -
Flags: review?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #557328 -
Flags: review? → review?(jorendorff)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: general → dholbert
|
||
Comment 2•13 years ago
|
||
Comment on attachment 557328 [details] [diff] [review]
fix: remove unused variable
Yep. Mental flotsam.
Attachment #557328 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•