683887 - do not restore window size after private browsing from jump list

Status: NEW

(Firefox :: Session Restore, defect)

Description

[dpokrovsky]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:6.0.1) Gecko/20100101 Firefox/6.0.1
Build ID: 20110830092941

Steps to reproduce:

Start FF right into private browsing from jump list. Change window size (in private browsing). Exit private browsing.


Actual results:

Window size ramains the same as it was in private browsing.


Expected results:

Window should be set to the size which was in last session of normal browsing.

Comment 1

[(no longer active)]

Hmm, Paul, do you think we should do this?  If yes, it's something that should be fixed in setBrowserState I think.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I thought we would already do this... If we're going through setBrowserState it looks like we should unless the dimensions were stripped off at some point

Comment 3

[(no longer active)]

Do they get stripped off in getBrowserState?  The PB service doesn't modify the browser state it receives from sessionstore.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I don't think so. Though I need to look at how the jump list stuff works again. If we start in private browsing mode & then switch we do something different than normal startup IIRC. I'll need to boot into win7 and see this in action.

Comment 5

[Mihaela Velimiroviciu (:mihaelav)]

Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a2) Gecko/20110915 Firefox/8.0a2; build ID: 20110915042012

Verified this on Aurora and could not reproduce.
Steps:
1. Start Aurora
2. Maximize browsed window
3. Start Private Browsig
4. Restore browser window/ change its dimension
5. Stop Private Browsing

Result: Browser displayed window as maximized

Comment 6

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110913 Firefox/9.0a1

Reproducible for me on the Nightly:

1. Start Firefox Private Browsing from jump list.
2. Minimize Firefox window.
3. Stop private browsing from the menu.

The window has the same dimensions as in Private browsing mode.

Comment 7

[u279076]

Confirming based on comment 5. Question is whether or not this is desired behaviour. If this is something that used to happen and it has regressed then we need a regression window. If this is as designed then we need to evaluate whether we want to change that design.

Pending developer/UX feedback.