Last Comment Bug 683895 - devicemanagerADB assumes /mnt/sdcard even if there is no sdcard available
: devicemanagerADB assumes /mnt/sdcard even if there is no sdcard available
Status: NEW
[android][tegra][mobile_unittests]
:
Product: Testing
Classification: Components
Component: New Frameworks (show other bugs)
: unspecified
: ARM Android
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-01 07:25 PDT by Joel Maher ( :jmaher )
Modified: 2012-09-14 10:09 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Joel Maher ( :jmaher ) 2011-09-01 07:25:10 PDT
we made a poor assumption in devicemanagerADB while looking for the deviceroot:
http://mxr.mozilla.org/mozilla-central/source/build/mobile/devicemanagerADB.py#368

If we do not have a sdcard on the device (tegra in my case), a directory /mnt/sdcard still exists.

We need a better check to see if /mnt/sdcard is a directory on a valid sdcard with rw permissions before assuming we are using it.

Currently the workaround is to create a /data/local/tests on the device before running tests.
Comment 1 Kartikaya Gupta (email:kats@mozilla.com) 2012-09-14 09:57:44 PDT
:jmaher, is there anything left to do here beyond what was done in bug 767449?
Comment 2 Joel Maher ( :jmaher ) 2012-09-14 10:09:26 PDT
:kats, just test it.  From looking at the work done in bug 767449, this should resolve most if not all of this current bug.

Note You need to log in before you can comment on or make changes to this bug.